Skip to content

Fix warnAlias mangling attrsets#457349

Merged
emilazy merged 1 commit intoNixOS:masterfrom
keysmashes:push-xoxwmppkkqkk
Nov 1, 2025
Merged

Fix warnAlias mangling attrsets#457349
emilazy merged 1 commit intoNixOS:masterfrom
keysmashes:push-xoxwmppkkqkk

Conversation

@keysmashes
Copy link
Contributor

This fixes an issue introduced in #456527.

Before:

$ nix-instantiate --eval --expr 'with import ./. {}; pkgs.hostPlatform.isLinux'
trace: evaluation warning: 'hostPlatform' has been renamed to/replaced by 'stdenv.hostPlatform'
error: attempt to call something which is not a function but a string: "isLinux"
       at «string»:1:39:
            1| with import ./. {}; pkgs.hostPlatform.isLinux
             |                                       ^

After:

$ nix-instantiate --eval --expr 'with import ./. {}; pkgs.hostPlatform.isLinux'
trace: evaluation warning: 'hostPlatform' has been renamed to/replaced by 'stdenv.hostPlatform'
true

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. 9.needs: reviewer This PR currently has no reviewers requested and needs attention. labels Oct 31, 2025
Copy link
Contributor

@trofi trofi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also fixes nix eval --impure --expr 'with import ./. {}; buildPlatform.aesSupport' for me. Thank you!

@nixpkgs-ci nixpkgs-ci bot added 12.approvals: 1 This PR was reviewed and approved by one person. and removed 9.needs: reviewer This PR currently has no reviewers requested and needs attention. labels Oct 31, 2025
Copy link
Member

@emilazy emilazy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Sorry for missing this.

@emilazy emilazy added this pull request to the merge queue Nov 1, 2025
@emilazy emilazy removed this pull request from the merge queue due to a manual request Nov 1, 2025
@emilazy
Copy link
Member

emilazy commented Nov 1, 2025

Could you add an “aliases:” prefix to the commit message? (Sorry for missing that too…)

@keysmashes
Copy link
Contributor Author

done!

@nixpkgs-ci nixpkgs-ci bot added 12.approvals: 2 This PR was reviewed and approved by two persons. and removed 12.approvals: 1 This PR was reviewed and approved by one person. labels Nov 1, 2025
@emilazy emilazy added this pull request to the merge queue Nov 1, 2025
@emilazy
Copy link
Member

emilazy commented Nov 1, 2025

Thanks!

Merged via the queue into NixOS:master with commit f604c3a Nov 1, 2025
29 of 31 checks passed
@keysmashes keysmashes deleted the push-xoxwmppkkqkk branch November 2, 2025 05:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. 12.approvals: 2 This PR was reviewed and approved by two persons.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants