darwin-aliases: cleanups and keep-sorted#455798
Open
qweered wants to merge 4 commits intoNixOS:masterfrom
Open
darwin-aliases: cleanups and keep-sorted#455798qweered wants to merge 4 commits intoNixOS:masterfrom
qweered wants to merge 4 commits intoNixOS:masterfrom
Conversation
nixpkgs-ci
bot
added
10.rebuild-darwin: 0
1 task
wolfgangwalther
previously approved these changes
Oct 26, 2025
nixpkgs-ci
bot
added
the
12.approvals: 1
qweered
force-pushed
the
darwin-aliases-keep-sorted
branch
from
8b318a0 to
7245618
Compare
qweered
changed the title
qweered
force-pushed
the
darwin-aliases-keep-sorted
branch
from
7245618 to
480e5d9
Compare
nixpkgs-ci
bot
removed
the
12.approvals: 1
wolfgangwalther
approved these changes
Nov 25, 2025
Contributor
wolfgangwalther
left a comment
wolfgangwalther
left a comment
There was a problem hiding this comment.
I don't think we necessarily need keep-sorted for such a small list, but it also doesn't hurt. It's already there now - and this removes some old throws, which makes sense to me.
wolfgangwalther
previously requested changes
Nov 25, 2025
nixpkgs-ci
bot
added
12.approvals: 1
qweered
force-pushed
the
darwin-aliases-keep-sorted
branch
2 times, most recently
from
c875873 to
c41b69a
Compare
nixpkgs-ci
bot
removed
the
2.status: merge conflict
qweered
force-pushed
the
darwin-aliases-keep-sorted
branch
2 times, most recently
from
622f77c to
429aa37
Compare
nixpkgs-ci
bot
added
the
6.topic: nodejs
Contributor
|
The new commit |
nixpkgs-ci
bot
added
the
2.status: merge conflict
qweered
force-pushed
the
darwin-aliases-keep-sorted
branch
from
429aa37 to
91cf5b0
Compare
nixpkgs-ci
bot
removed
the
2.status: merge conflict
qweered
force-pushed
the
darwin-aliases-keep-sorted
branch
from
91cf5b0 to
3b6b9ff
Compare
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/prs-ready-for-review/3032/6385 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Things done
passthru.tests.nixpkgs-reviewon this PR. See nixpkgs-review usage../result/bin/.Add a 👍 reaction to pull requests you find important.