aliases: cleanups and keep-sorted

[qweered]

• Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

[wolfgangwalther]

Left a few comments, the pattern should be clear: Let's move all manual modifications into commits before the keep-sorted one, so that we can easily recreate the latter.

[qweered]

Done

[emilazy]

Overall neutral on this. Some of the organization this disrupts is intentional / something I’ve found useful, but OTOH there are a lot of arbitrary weirdnesses in the file too. The aliases.nix file is somewhat unmaintainable with the current system in general, so I guess I’m really fine with any ordering :)

The general clean‐ups are definitely good, and may help with a final round of dropping with #427017.

cc @wolfgangwalther – do we want to land this? I think I’ve talked myself into it being a good idea while writing this.

[qweered]

Note: throw '' '' (aka multiline) need to be replaced with default throw " " for keep sorted to work

[wolfgangwalther]

Good stuff, thank you!

I went through the commits, adjusted the commit messages a bit and move some more "preserve" aliases to the top in the second commit. I also dropped the commit that changed '' to " for multi-line messages, because I believe this changes the messages contents.

With the split, I was able to recreate the last commit easily, nice.

(I also adjusted the commit hash in .git-blame-ignore-revs after my rebase)

[wolfgangwalther]

Note: throw '' need to be replaced with throw " for keep sorted to work

Oh, I didn't notice that, let me see whether I broke that with the latest drop of that commit.

[wolfgangwalther]

Note: throw '' need to be replaced with throw " for keep sorted to work

Oh, I didn't notice that, let me see whether I broke that with the latest drop of that commit.

Indeed, I see what you mean. It's odd that treefmt ran mostly fine the first time - and only when I ran it again, it started to break everything. I put that commit back in.

[mdaniels5757]

Note: throw '' need to be replaced with throw " for keep sorted to work

Oh, I didn't notice that, let me see whether I broke that with the latest drop of that commit.

Indeed, I see what you mean. It's odd that treefmt ran mostly fine the first time - and only when I ran it again, it started to break everything. I put that commit back in.

Does block=yes fix this? https://github.com/google/keep-sorted?tab=readme-ov-file#blocks

[mdaniels5757]

Oops it already has it :)

[wolfgangwalther]

Does block=yes fix this? https://github.com/google/keep-sorted?tab=readme-ov-file#blocks

The problem is that block=yes works on balancing parens, quotes etc. - but has no idea of "double single quote" that we use for strings in nix. So for keep-sorted, the balancing ends with the opening quote for these strings - and then everything starts to break.

[qweered]

🎉 Same for darwin-aliases #455798

[imincik]

@qweered , @wolfgangwalther ,

it looks to me that this PR broke pkgs/top-level/aliases.nix file.

I get error: undefined variable 'xproto' error message when trying to evaluate it. Looks related to this change.

[qweered]

Working on a fix