top-level/stage: assert no by-name overwrites

[wolfgangwalther]

This asserts that no by-name packages are overwritten by definitions in all-packages.nix.

The relevant code from

nixpkgs/pkgs/top-level/by-name-overlay.nix

Lines 49 to 57 in 804ab2e

	{
	# This attribute is necessary to allow CI to ensure that all packages defined in `pkgs/by-name`
	# don't have an overriding definition in `all-packages.nix` with an empty (`{ }`) second `callPackage` argument.
	# It achieves that with an overlay that modifies both `callPackage` and this attribute to signal whether `callPackage` is used
	# and whether it's defined by this file here or `all-packages.nix`.
	# TODO: This can be removed once `pkgs/by-name` can handle custom `callPackage` arguments without `all-packages.nix` (or any other way of achieving the same result).
	# Because at that point the code in ./stage.nix can be changed to not allow definitions in `all-packages.nix` to override ones from `pkgs/by-name` anymore and throw an error if that happens instead.
	_internalCallByNamePackageFile = file: self.callPackage file { };
	}

can only be removed once nixpkgs-vet has removed the check, too.

Things done

• python313Packages.nixpkgs-plugin-update: init from maintainer script  #453943
• top-level/all-packages: remove overwriting by-name callPackage #453948
• Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

---

Add a 👍 reaction to pull requests you find important.

[wolfgangwalther]

Excuse me, GitHub? I did not close this.

Bot the combo of close + force push... does not allow me to re-open it again. Will need to open a new PR, gnah...

New PR in #454525.

[philiptaron]

What even happened?!