various: migrate applications/audio to by-name/ part 2

[pancaek]

Things done

• Built on platform:
  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
• Tested, as applicable:
  • NixOS tests in nixos/tests.
  • Package tests at passthru.tests.
  • Tests in lib/tests or pkgs/test for functions and "core" functionality.
• Ran nixpkgs-review on this PR. See nixpkgs-review usage.
• Tested basic functionality of all binary files, usually in ./result/bin/.
• Nixpkgs Release Notes
  • Package update: when the change is major or breaking.
• NixOS Release Notes
  • Module addition: when adding a new NixOS module.
  • Module update: when the change is significant.
• Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

---

Add a 👍 reaction to pull requests you find important.

[wolfgangwalther]

The commit message in mbrola(-voices): move to by-name/ is wrong - you need to use {} instead of () for the right expansion syntax, so that ofborg can pick this up correctly.

(have not checked the other commit messages)

[wolfgangwalther]

Ah, I missed that the same commit message needs a comma, too:

-mbrola{-voices}: move to by-name/
+mbrola{,-voices}: move to by-name/

[pancaek]

(sorry about the rebases, merge conflict)

I think this is actually ready, I did want to check in about a couple of the packages I moved though. Was hoping to be able to migrate the whole thing here, but oh well.

• raysession
• pithos
• greg
• patchance
• petrifoo

I was a little unsure if these violated this paragraph about by-name/

Note that callPackage definitions in all-packages.nix with custom arguments should not be removed. That is a backwards-incompatible change because it changes the .override interface. Such packages may still be moved to pkgs/by-name however, in order to avoid the slightly superficial choice of directory / category in which the default.nix file was placed, but please keep the definition in all-packages.nix using callPackage. See also changing implicit attribute defaults.

I can adjust those ones more if needed, but I had a hard time following that section

[wolfgangwalther]

I was a little unsure if these violated this paragraph about by-name/

Note that callPackage definitions in all-packages.nix with custom arguments should not be removed. That is a backwards-incompatible change because it changes the .override interface. Such packages may still be moved to pkgs/by-name however, in order to avoid the slightly superficial choice of directory / category in which the default.nix file was placed, but please keep the definition in all-packages.nix using callPackage. See also changing implicit attribute defaults.

I can adjust those ones more if needed, but I had a hard time following that section

This advice will be outdated very soon, when we merge #454147. So it's fine to either not deal with these right now or to migrate them to a form where no callPackage remains in all-packages.nix.

[wolfgangwalther]

Just the nit about the commit message.

[wolfgangwalther]

(commit message is not really relevant, because there are no rebuilds anyway - so doesn't matter that ofborg can't pick it up!)

[qweered]

This should be in aliases

[wolfgangwalther]

I'm not 100% sure about which of the two should be the alias.

I am 100% sure that this out of scope for this PR, though. This was not introduced here.

Feel free to open a PR to improve it!