Skip to content

vicinae: init at 0.15.5 #451675

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JohnRTitor merged 3 commits into from
Oct 26, 2025
Merged

vicinae: init at 0.15.5 #451675

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c58a7d1
Add self to maintainer list
zstg Oct 13, 2025
ec212ce
vicinae: init at 0.15.5
zstg Oct 13, 2025
c3de656
vicinae: add dawnofmidnight as maintainer
JohnRTitor Oct 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions maintainers/maintainer-list.nix
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29071,6 +29071,12 @@
githubId = 332534;
name = "Zach Shipko";
};
zstg = {
email = "zestig@duck.com";
github = "zstg";
githubId = 69384921;
name = "ZeStig";
};
ztzg = {
email = "dd@crosstwine.com";
github = "ztzg";
Expand Down
101 changes: 101 additions & 0 deletions pkgs/by-name/vi/vicinae/package.nix
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,101 @@
{
cmake,
cmark-gfm,
fetchFromGitHub,
fetchNpmDeps,
grpc-tools,
kdePackages,
lib,
libqalculate,
minizip,
ninja,
nodejs,
npmHooks,
pkg-config,
protobuf,
qt6,
rapidfuzz-cpp,
stdenv,
wayland,
}:
stdenv.mkDerivation (finalAttrs: {
pname = "vicinae";
version = "0.15.5";

src = fetchFromGitHub {
owner = "vicinaehq";
repo = "vicinae";
tag = "v${finalAttrs.version}";
hash = "sha256-3pKexTUWfohL/S/yWsVMShmtMlBFI9zsd7NFzySKG0w=";
};

apiDeps = fetchNpmDeps {
src = "${finalAttrs.src}/typescript/api";
hash = "sha256-dSHEzw15lSRRbldl9PljuWFf2htdG+HgSeKPAB88RBg=";
};

extensionManagerDeps = fetchNpmDeps {
src = "${finalAttrs.src}/typescript/extension-manager";
hash = "sha256-TCT7uZRZn4rsLA/z2yLeK5Bt4DJPmdSC4zkmuCxTtc8=";
};

cmakeFlags = lib.mapAttrsToList lib.cmakeFeature {
"VICINAE_GIT_TAG" = "v${finalAttrs.version}";
"VICINAE_PROVENANCE" = "nix";
"INSTALL_NODE_MODULES" = "OFF";
"CMAKE_INSTALL_PREFIX" = placeholder "out";
"CMAKE_INSTALL_DATAROOTDIR" = "share";
"CMAKE_INSTALL_BINDIR" = "bin";
"CMAKE_INSTALL_LIBDIR" = "lib";
};

nativeBuildInputs = [
cmake
ninja
nodejs
pkg-config
protobuf
qt6.wrapQtAppsHook
];

buildInputs = [
cmark-gfm
grpc-tools
kdePackages.layer-shell-qt
kdePackages.qtkeychain
libqalculate
minizip
nodejs
protobuf
qt6.qtbase
qt6.qtsvg
qt6.qtwayland
rapidfuzz-cpp
wayland
];

postPatch = ''
local postPatchHooks=()
source ${npmHooks.npmConfigHook}/nix-support/setup-hook
npmRoot=typescript/api npmDeps=${finalAttrs.apiDeps} npmConfigHook
npmRoot=typescript/extension-manager npmDeps=${finalAttrs.extensionManagerDeps} npmConfigHook
'';

qtWrapperArgs = [
"--prefix PATH : ${
lib.makeBinPath [
nodejs
(placeholder "out")
]
}"
];

meta = {
description = "A focused launcher for your desktop — native, fast, extensible";
homepage = "https://github.com/vicinaehq/vicinae";
license = lib.licenses.gpl3Plus;
maintainers = with lib.maintainers; [ zstg ];

@whispersofthedawn whispersofthedawn Oct 26, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
maintainers = with lib.maintainers; [ zstg ];
maintainers = [ lib.maintainers.zstg ];

@JohnRTitor JohnRTitor Oct 26, 2025

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's a stylistic change, and will need to be reversed if more maintainers are added later.

@whispersofthedawn whispersofthedawn Oct 26, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah okay. I was under the impression that with was generally being phased out (I'm not particularly involved in nixpkgs things), but if that's the norm, sounds good to me.

@JohnRTitor JohnRTitor Oct 26, 2025

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

with lib is being phased out for meta and other attrs. Using with in a smaller scope like meta.maintainers in fine, using it for the whole meta attr isn't.

@JohnRTitor JohnRTitor Oct 26, 2025 •
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Anyways, I won't be able to maintain this. I applied the changes as a commiter. And given chaotic-cx/nyx#1220 (comment), would any of you like to co maintain this package?

@whispersofthedawn whispersofthedawn Oct 26, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd be willing to handle updates and such if necessary, but I have not maintained nixpkgs packages before, and so would need to be added to the maintainer-list. If you could do that on top of this PR, we can provide a patch, or we could open a quick PR just to add us as a maintainer.

Patch to maintainer list 
From 833511c8a8feafc0d05be8a0836bbaa0f7cc4a1a Mon Sep 17 00:00:00 2001
From: dawnofmidnight <dawnofmidnight@duck.com>
Date: Sun, 26 Oct 2025 12:45:09 -0400
Subject: [PATCH] maintainers: add dawnofmidnight

---
 maintainers/maintainer-list.nix | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/maintainers/maintainer-list.nix b/maintainers/maintainer-list.nix
index bb777bcd9e45..526567194b82 100644
--- a/maintainers/maintainer-list.nix
+++ b/maintainers/maintainer-list.nix
@@ -5960,6 +5960,12 @@
     githubId = 49904992;
     name = "Dawid Sowa";
   };
+  dawnofmidnight = {
+    email = "dawnofmidnight@duck.com";
+    github = "dawnofmidnight";
+    githubId = 78233879;
+    name = "whispers";
+  };
   dawoox = {
     email = "contact@antoinebellanger.fr";
     github = "Dawoox";
--
2.51.0

@JohnRTitor JohnRTitor Oct 26, 2025

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done. Feel free to ping me if you want to get an update PR merged.

platforms = lib.platforms.linux;
mainProgram = "vicinae";
};
})
Loading