Conversation
|
Have you seen vicinaehq/vicinae#245 by @bendi-github? This PR here seems to be derived from what is available upstream in Adapted version of vicinae#245{
cmake,
cmark-gfm,
fetchFromGitHub,
fetchNpmDeps,
grpc-tools,
kdePackages,
lib,
libqalculate,
minizip,
ninja,
nodejs,
npmHooks,
pkg-config,
protobuf,
qt6,
rapidfuzz-cpp,
stdenv,
wayland,
}:
stdenv.mkDerivation (
finalAttrs:
let
apiDeps = fetchNpmDeps {
src = "${finalAttrs.src}/typescript/api";
hash = "sha256-dSHEzw15lSRRbldl9PljuWFf2htdG+HgSeKPAB88RBg=";
};
extensionManagerDeps = fetchNpmDeps {
src = "${finalAttrs.src}/typescript/extension-manager";
hash = "sha256-TCT7uZRZn4rsLA/z2yLeK5Bt4DJPmdSC4zkmuCxTtc8=";
};
in
{
pname = "vicinae";
version = "0.15.3";
src = fetchFromGitHub {
owner = "vicinaehq";
repo = "vicinae";
tag = "v${finalAttrs.version}";
hash = "sha256-wmlnRd5/imOkN2g3jiOH4hdblDH6XSrBS7KzOqRhPHc=";
};
cmakeFlags = [
"-DVICINAE_GIT_TAG=v${finalAttrs.version}"
"-DVICINAE_PROVENANCE=nix"
"-DINSTALL_NODE_MODULES=OFF"
"-DCMAKE_INSTALL_PREFIX=${placeholder "out"}"
"-DCMAKE_INSTALL_DATAROOTDIR=share"
"-DCMAKE_INSTALL_BINDIR=bin"
"-DCMAKE_INSTALL_LIBDIR=lib"
];
nativeBuildInputs = [
cmake
ninja
nodejs
pkg-config
protobuf
qt6.wrapQtAppsHook
];
buildInputs = [
cmark-gfm
grpc-tools
kdePackages.layer-shell-qt
kdePackages.qtkeychain
libqalculate
minizip
nodejs
protobuf
qt6.qtbase
qt6.qtsvg
qt6.qtwayland
rapidfuzz-cpp
wayland
];
postPatch = ''
local postPatchHooks=()
source ${npmHooks.npmConfigHook}/nix-support/setup-hook
npmRoot=typescript/api npmDeps=${apiDeps} npmConfigHook
npmRoot=typescript/extension-manager npmDeps=${extensionManagerDeps} npmConfigHook
'';
postFixup = ''
wrapProgram "$out/bin/vicinae" --prefix PATH : ${
lib.makeBinPath [
nodejs
(placeholder "out")
]
}
'';
meta = {
description = "A focused launcher for your desktop — native, fast, extensible";
homepage = "https://github.com/vicinaehq/vicinae";
license = lib.licenses.gpl3Plus;
mainProgram = "vicinae";
maintainers = [ ];
platforms = lib.platforms.linux;
};
}
)(As a minor nicety, this also happens to build significantly faster (6m55s vs 17m34s on my machine) for reasons entirely unknown to me.) |
i agree that we should take this chance to clean up the build. |
|
Also the version is outdated already so we should bump that |
|
CC @schromp @dawnofmidnight for review |
pkgs/by-name/vi/vicinae/package.nix
Outdated
| description = "A focused launcher for your desktop — native, fast, extensible"; | ||
| homepage = "https://github.com/vicinaehq/vicinae"; | ||
| license = lib.licenses.gpl3Plus; | ||
| maintainers = with lib.maintainers; [ zstg ]; |
There was a problem hiding this comment.
| maintainers = with lib.maintainers; [ zstg ]; | |
| maintainers = [ lib.maintainers.zstg ]; |
There was a problem hiding this comment.
That's a stylistic change, and will need to be reversed if more maintainers are added later.
There was a problem hiding this comment.
Ah okay. I was under the impression that with was generally being phased out (I'm not particularly involved in nixpkgs things), but if that's the norm, sounds good to me.
There was a problem hiding this comment.
with lib is being phased out for meta and other attrs. Using with in a smaller scope like meta.maintainers in fine, using it for the whole meta attr isn't.
There was a problem hiding this comment.
Anyways, I won't be able to maintain this. I applied the changes as a commiter. And given chaotic-cx/nyx#1220 (comment), would any of you like to co maintain this package?
There was a problem hiding this comment.
I'd be willing to handle updates and such if necessary, but I have not maintained nixpkgs packages before, and so would need to be added to the maintainer-list. If you could do that on top of this PR, we can provide a patch, or we could open a quick PR just to add us as a maintainer.
Patch to maintainer list
From 833511c8a8feafc0d05be8a0836bbaa0f7cc4a1a Mon Sep 17 00:00:00 2001
From: dawnofmidnight <dawnofmidnight@duck.com>
Date: Sun, 26 Oct 2025 12:45:09 -0400
Subject: [PATCH] maintainers: add dawnofmidnight
---
maintainers/maintainer-list.nix | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/maintainers/maintainer-list.nix b/maintainers/maintainer-list.nix
index bb777bcd9e45..526567194b82 100644
--- a/maintainers/maintainer-list.nix
+++ b/maintainers/maintainer-list.nix
@@ -5960,6 +5960,12 @@
githubId = 49904992;
name = "Dawid Sowa";
};
+ dawnofmidnight = {
+ email = "dawnofmidnight@duck.com";
+ github = "dawnofmidnight";
+ githubId = 78233879;
+ name = "whispers";
+ };
dawoox = {
email = "contact@antoinebellanger.fr";
github = "Dawoox";
--
2.51.0There was a problem hiding this comment.
Done. Feel free to ping me if you want to get an update PR merged.
|
Thank you for merging @JohnRTitor . Shall I bump the version to 0.15.6? |
|
Go ahead, you don't need anyone's permission. |
Packaged vicinae.
Documentation: https://docs.vicinae.com/
Things done
passthru.tests.nixpkgs-reviewon this PR. See nixpkgs-review usage../result/bin/.Add a 👍 reaction to pull requests you find important.