[Backport release-25.05] llvmPackages_21: 21.1.0-rc1 -> 21.1.0-rc2#448660
[Backport release-25.05] llvmPackages_21: 21.1.0-rc1 -> 21.1.0-rc2#448660mdaniels5757 wants to merge 2 commits intoNixOS:release-25.05from
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
|
afd9652 fixes LLVM libc |
59ae08b to
d3f3019
Compare
There was a problem hiding this comment.
This report is automatically generated by the PR / Check / cherry-pick CI workflow.
Some of the commits in this PR require the author's and reviewer's attention.
Sometimes it is not possible to cherry-pick exactly the same patch.
This most frequently happens when resolving merge conflicts.
The range-diff will help to review the resolution of conflicts.
If you need to merge this PR despite the warnings, please dismiss this review shortly before merging.
Warning
Difference between d3f3019 and original afd9652 may warrant inspection.
Show diff
@@ Metadata
## Commit message ##
llvmPackages_21.libc: fix building
+ (cherry picked from commit afd965280e1f52dace0327474b6176f23e8c386f)
+
## pkgs/development/compilers/llvm/common/libc/default.nix ##
@@
let
pname = "libc";
-- src' = runCommand "${pname}-src-${version}" { } (''
+- src' = runCommand "${pname}-src-${version}" { } ''
- mkdir -p "$out"
- cp -r ${monorepoSrc}/cmake "$out"
- cp -r ${monorepoSrc}/runtimes "$out"
- cp -r ${monorepoSrc}/llvm "$out"
- cp -r ${monorepoSrc}/compiler-rt "$out"
- cp -r ${monorepoSrc}/${pname} "$out"
-- '');
+- '';
+ src' = runCommand "${pname}-src-${version}" { } (
+ ''
+ mkdir -p "$out"
Hint: The full diffs are also available in the runner logs with slightly better highlighting.
|
Thanks, added to the backport. |
|
The cherry-pick failure is due to #448813. |
|
| + lib.optionalString (lib.versionAtLeast release_version "21") '' | ||
| cp -r ${monorepoSrc}/third-party "$out" | ||
| '' | ||
| ); |
There was a problem hiding this comment.
This hunk isn't in the original commit. Does that mean there's another commit we should have backported but didn't?
There was a problem hiding this comment.
Well, that commit comes from the same PR as the commit I just mentioned. Both are from #437137.
|
Wait I missed that #442866 contains this update, and a couple more. This PR should be closed, I think; I'll request the libc-fixing commit be cherry-picked there. |
Manual backport of #429385 and afd9652 to
release-25.05.