[25.05] LLVM 21 updates#442866
Conversation
|
|
(llvmPackages_21.libc already fails on the release branch) |
mdaniels5757
left a comment
There was a problem hiding this comment.
This should probably cherry-pick afd9652 to fix LLVM libc.
b3ea14c to
d5e37f8
Compare
d5e37f8 to
5be56bc
Compare
There was a problem hiding this comment.
This report is automatically generated by the PR / Check / cherry-pick CI workflow.
Some of the commits in this PR require the author's and reviewer's attention.
Sometimes it is not possible to cherry-pick exactly the same patch.
This most frequently happens when resolving merge conflicts.
The range-diff will help to review the resolution of conflicts.
If you need to merge this PR despite the warnings, please dismiss this review shortly before merging.
Warning
Difference between b122925 and original afd9652 may warrant inspection.
Show diff
@@ Metadata
## Commit message ##
llvmPackages_21.libc: fix building
+ (cherry picked from commit afd965280e1f52dace0327474b6176f23e8c386f)
+
## pkgs/development/compilers/llvm/common/libc/default.nix ##
@@
let
pname = "libc";
-- src' = runCommand "${pname}-src-${version}" { } (''
+- src' = runCommand "${pname}-src-${version}" { } ''
- mkdir -p "$out"
- cp -r ${monorepoSrc}/cmake "$out"
- cp -r ${monorepoSrc}/runtimes "$out"
- cp -r ${monorepoSrc}/llvm "$out"
- cp -r ${monorepoSrc}/compiler-rt "$out"
- cp -r ${monorepoSrc}/${pname} "$out"
-- '');
+- '';
+ src' = runCommand "${pname}-src-${version}" { } (
+ ''
+ mkdir -p "$out"
Hint: The full diffs are also available in the runner logs with slightly better highlighting.
|
mdaniels5757
left a comment
There was a problem hiding this comment.
Approved automatically following the successful run of nixpkgs-review.
Trivial diff due to merge conflict.
acb072b
Things done
passthru.tests.nixpkgs-reviewon this PR. See nixpkgs-review usage../result/bin/.Add a 👍 reaction to pull requests you find important.