atuin-desktop: init at 0.1.3 #448422
atuin-desktop: init at 0.1.3 #448422
Conversation
nixpkgs-ci
bot
added
the
12.first-time contribution
randoneering
force-pushed
the
init/atuin-desktop
branch
from
e035f5d to
fc08302
Compare
| echo "=== Debugging binary ===" | ||
| if [ -f "$out/bin/atuin-desktop" ]; then | ||
| echo "Binary exists" | ||
| file "$out/bin/atuin-desktop" | ||
| ldd "$out/bin/atuin-desktop" || echo "ldd failed" | ||
| readelf -l "$out/bin/atuin-desktop" | grep interpreter || echo "No interpreter found" | ||
| else | ||
| echo "Binary not found, listing contents:" | ||
| find "$out" -name "*atuin*" -type f | ||
| fi | ||
| echo "=== End debugging ===" | ||
| find $out/bin -type f -executable | while read -r bin; do | ||
| echo "Patching binary: $bin" | ||
| # Check if it's an ELF binary | ||
| if file "$bin" | grep -q "ELF"; then | ||
| echo " Setting interpreter..." | ||
| patchelf --set-interpreter ${stdenv.cc.bintools.dynamicLinker} "$bin" || echo " Failed to set interpreter" | ||
| echo " Setting rpath..." | ||
| patchelf --set-rpath ${lib.makeLibraryPath buildInputs} "$bin" || echo " Failed to set rpath" | ||
| echo " Shrinking rpath..." | ||
| patchelf --shrink-rpath "$bin" || echo " Failed to shrink rpath" | ||
| fi | ||
| done |
There was a problem hiding this comment.
Can you reduce this to only keep the patchelf commands?
There was a problem hiding this comment.
I attempted to remove this section but failed to get the package to build successfully. I would like to leave this is until I can trim this down. The build would succeed with just the patchelf statements, but the binary would fail to run:
Could not start dynamically linked executable: ./result/bin/atuin-desktop
NixOS cannot run dynamically linked executables intended for generic
linux environments out of the box. For more information, see:
https://nix.dev/permalink/stub-ld
nixpkgs-ci
bot
added
10.rebuild-linux: 1-10
randoneering
force-pushed
the
init/atuin-desktop
branch
from
1cbbe7b to
5972e30
Compare
randoneering
force-pushed
the
init/atuin-desktop
branch
from
5972e30 to
d34bcc2
Compare
nixpkgs-ci
bot
added
the
12.approvals: 1
| maintainers = with lib.maintainers; [ | ||
| randoneering | ||
| dzervas | ||
| ]; |
There was a problem hiding this comment.
| ]; | |
| ]; | |
| sourceProvenance = with lib.sourceTypes; [ binaryNativeCode ]; |
| ''; | ||
|
|
||
| meta = { | ||
| description = "Atuin Desktop"; |
There was a problem hiding this comment.
Could you flesh out the description a bit more? Maybe like
| description = "Atuin Desktop"; | |
| description = "GUI application for creating executable runbooks with shell commands"; |
There was a problem hiding this comment.
Oh geez. Of course! Sorry I missed carrying this over from my local package.
| preFixup = '' | ||
| gappsWrapperArgs+=( | ||
| # Ensure the binary can find all required libraries | ||
| --prefix LD_LIBRARY_PATH : ${lib.makeLibraryPath finalAttrs.buildInputs} |
There was a problem hiding this comment.
Does the patchelf stuff not fix this already?
There was a problem hiding this comment.
I'll double check. I don't think it did but I'll verify when I'm back at my computer.
|
The follow PR is for the atuin-desktop package built from source rather than the deb binary. I am going to close this as we should be focusing on building from source. Thanks everyone for your comments and review! |
4 participants
The following pull request is for adding Atuin-Desktop to nixpkgs. Atuin-Desktop is an Open Source app that provides executable runbooks that incorporate executable code into documentation. You can read more by clicking the links below:
Github Repo
Website Link
Things done
passthru.tests.nixpkgs-reviewon this PR. See nixpkgs-review usage../result/bin/.Add a 👍 reaction to pull requests you find important.