Skip to content

Conversation

@randoneering
Copy link

The following pull request is for adding Atuin-Desktop to nixpkgs. Atuin-Desktop is an Open Source app that provides executable runbooks that incorporate executable code into documentation. You can read more by clicking the links below:

Github Repo

Website Link

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

@randoneering
Copy link
Author

This is my first attempt so please be gentle! I was able to build this locally on NixOS 25.05.

@nixpkgs-ci nixpkgs-ci bot added the 12.first-time contribution This PR is the author's first one; please be gentle! label Oct 3, 2025
@RossSmyth
Copy link
Contributor

RossSmyth commented Oct 3, 2025

Could you please follow the PR format. The PR title, and the commit names.

Your commits should look like:

  1. A commit adding yourself to the maintain list
  2. The commit adding the package

And only those two commits in that order.

I also wonder why this is not built from source? Looks like it's possible.

@randoneering
Copy link
Author

Sure. I'll go ahead and rebuild it. Honestly, I was a bit confused on what format to use with all the links in the contribution document. My apologies. Again, this is my first attempt at a nix package.

@Adda0
Copy link
Contributor

Adda0 commented Oct 3, 2025

It can be built from source. I am wrangling with some build issues now, though. It is possible to first only use the pre-built binary, and only then change to compiling from source when I or someone figures it out.

Copy link
Contributor

@Adda0 Adda0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, thank you for trying to help out. Please, first read the contributing guidelines in the repo to modify the PR accordingly. Some quick notes.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo in the package name.

version = "0.1.0";

src = fetchurl {
url = "https://github.com/atuinsh/desktop/releases/download/v0.1.0/Atuin_Desktop_0.1.0_amd64.deb";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should reference ${version} from above to minimize repeating yourself.

pkg-config,
}:

stdenv.mkDerivation rec {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using (final: prev: { would be the preferred approach.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. only overrides support two-arg lambdas, a primary mkDerivation call only supports (final: {})-type lambdas
  2. until those lambdas are made to propagate differently than rec (they currently don't) and are documented (they currently aren't), let's not suggest that: CONTRIBUTING: discourage style reviews not based on written rules #445898

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. True, we are using the default mkDerivation here. Never mind.
  2. Sure.

Consider this issue resolved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

12.first-time contribution This PR is the author's first one; please be gentle!

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants