Skip to content

superlu: fix build with clang21 #448396

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
NickCao merged 4 commits into from
Oct 8, 2025
Merged

superlu: fix build with clang21 #448396

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
f2e23a1
superlu: remove unused lapack
qbisi Oct 3, 2025
04e483e
superlu: use generic blas vendor on all platforms
qbisi Oct 4, 2025
f90df7f
superlu: fix build with clang21
qbisi Oct 4, 2025
7c30eb5
superlu: 7.0.0 -> 7.0.1
qbisi Oct 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 8 additions & 8 deletions pkgs/by-name/su/superlu/package.nix
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,14 +7,11 @@
ninja,
gfortran,
blas,
lapack,
}:

assert (!blas.isILP64) && (!lapack.isILP64);

stdenv.mkDerivation (finalAttrs: {
pname = "superlu";
version = "7.0.0";
version = "7.0.1";

src = fetchFromGitHub {
owner = "xiaoyeli";
Expand All @@ -27,7 +24,7 @@ stdenv.mkDerivation (finalAttrs: {
# * <https://github.com/xiaoyeli/superlu/blob/0bbd6571bd839d866bff6a8ff1eaa812a8c31463/License.txt#L32-L65>
# * <https://salsa.debian.org/science-team/superlu/-/blob/0acab1b41f332f2f2e3b0b5d28ba7fc9f7539533/debian/copyright>
postFetch = "rm $out/SRC/mc64ad.* $out/DOC/*.pdf";
hash = "sha256-iJiVyY+/vr6kll8FCunvZ8rKBj+w+Rnj4F696XW9xFc=";
hash = "sha256-MiQPhYIGZbvmtpIojrNzTG4Xao7lc4Ks/FtxlfdAKmQ=";
};

patches = [
Expand All @@ -37,6 +34,11 @@ stdenv.mkDerivation (finalAttrs: {
})
];

# Prevent clang from crashing when compiling slatms.c from SuperLU’s matgen test code.
postPatch = lib.optionalString stdenv.cc.isClang ''
echo 'target_compile_options(matgen PRIVATE -fno-vectorize)' >> TESTING/MATGEN/CMakeLists.txt
'';

nativeBuildInputs = [
cmake
ninja
Expand All @@ -48,11 +50,9 @@ stdenv.mkDerivation (finalAttrs: {
cmakeFlags = [
(lib.cmakeBool "BUILD_SHARED_LIBS" true)
(lib.cmakeBool "enable_fortran" true)
]
++ lib.optionals stdenv.hostPlatform.isDarwin [
# prevent cmake from using Accelerate, which causes tests to segfault
# https://github.com/xiaoyeli/superlu/issues/155
"-DBLA_VENDOR=Generic"
(lib.cmakeFeature "BLA_VENDOR" "Generic")
];

doCheck = true;
Expand Down
Loading