[Backport release-25.05] nixos/lomiri: Exclude Morph Browser by default#443158
Merged
OPNA2608 merged 3 commits intoNixOS:release-25.05from Sep 27, 2025
Conversation
Qt5 qtwebengine will be marked insecure, so this would block the entire DE from being usable. Epiphany seems to work as a replacement until Morph can be built with Qt6. Content-Hub test will still need adjustment, but keeping it out of this to make future reverting easier. (cherry picked from commit 5063462)
… using Gallery app instead (cherry picked from commit 8ae6f58) Manually adjusted some mouse click coords in the test, due to different mouse handling between stable and unstable.
OfBorg please... (cherry picked from commit f03a8ca)
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
This report is automatically generated by the PR / Check / cherry-pick CI workflow.
Some of the commits in this PR require the author's and reviewer's attention.
Sometimes it is not possible to cherry-pick exactly the same patch.
This most frequently happens when resolving merge conflicts.
The range-diff will help to review the resolution of conflicts.
If you need to merge this PR despite the warnings, please dismiss this review shortly before merging.
Warning
Difference between 9214d9f and original 8ae6f58 may warrant inspection.
Show diff
@@ Metadata
## Commit message ##
nixosTests.lomiri.desktop-appinteractions: Switch Content-Hub test to using Gallery app instead
+ (cherry picked from commit 8ae6f582ef7b2326f99e096fd56f551d1a66d00d)
+
+ Manually adjusted some mouse click coords in the test, due to different mouse handling between stable and unstable.
+
## nixos/tests/lomiri.nix ##
@@ nixos/tests/lomiri.nix: in
machine.send_key("ret")
@@ nixos/tests/lomiri.nix: in
machine.screenshot("settings_lomiri-content-hub_peers")
- # Select Morph as content source
-- mouse_click(340, 80)
+- mouse_click(370, 100)
+ # Select Gallery as content source
-+ mouse_click(460, 80)
++ mouse_click(500, 100)
- # Expect Morph to be brought into the foreground, with its Downloads page open
- wait_for_text("No downloads")
Hint: The full diffs are also available in the runner logs with slightly better highlighting.
1 task
nixpkgs-ci
bot
added
10.rebuild-linux: 1-10
Contributor
Author
|
I guess let's send this - Qt6 Morph Browser is still abit away, and vulnerabilities are exploitable… |
OPNA2608
dismissed
github-actions[bot]’s stale review
Difference from version on master is fine.
Merged
via the queue into
NixOS:release-25.05
with commit Sep 27, 2025
a32b7e3
37 of 38 checks passed
OPNA2608
deleted the
backport/25.05/fix/lomiri/morph-browser-qtwebengine-insecure
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Manual backport of #436723, so #439081 can eventually get backported.
Ripping away the only properly-working & integrated web browser of the DE under users' feet, especially on the stable branch, is really giving me stomach pains… But it uses a known-vulnerable browser engine, so I guess we gotta do it. 🫤
Things done
passthru.tests.nixpkgs-reviewon this PR. See nixpkgs-review usage../result/bin/.Add a 👍 reaction to pull requests you find important.