[Backport release-25.05] nixos/lomiri: Exclude Morph Browser by default#439340
Closed
mdaniels5757 wants to merge 3 commits intoNixOS:release-25.05from
Closed
[Backport release-25.05] nixos/lomiri: Exclude Morph Browser by default#439340mdaniels5757 wants to merge 3 commits intoNixOS:release-25.05from
mdaniels5757 wants to merge 3 commits intoNixOS:release-25.05from
Conversation
Qt5 qtwebengine will be marked insecure, so this would block the entire DE from being usable. Epiphany seems to work as a replacement until Morph can be built with Qt6. Content-Hub test will still need adjustment, but keeping it out of this to make future reverting easier. (cherry picked from commit 5063462)
… using Gallery app instead (cherry picked from commit 8ae6f58)
OfBorg please... (cherry picked from commit f03a8ca)
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
This report is automatically generated by the PR / Check / cherry-pick CI workflow.
Some of the commits in this PR require the author's and reviewer's attention.
Sometimes it is not possible to cherry-pick exactly the same patch.
This most frequently happens when resolving merge conflicts.
The range-diff will help to review the resolution of conflicts.
If you need to merge this PR despite the warnings, please dismiss this review shortly before merging.
Warning
Difference between 18ed3bc and original 8ae6f58 may warrant inspection.
Show diff
@@ Metadata
## Commit message ##
nixosTests.lomiri.desktop-appinteractions: Switch Content-Hub test to using Gallery app instead
+ (cherry picked from commit 8ae6f582ef7b2326f99e096fd56f551d1a66d00d)
+
## nixos/tests/lomiri.nix ##
@@ nixos/tests/lomiri.nix: in
machine.send_key("ret")
@@ nixos/tests/lomiri.nix: in
machine.screenshot("settings_lomiri-content-hub_peers")
- # Select Morph as content source
-- mouse_click(340, 80)
+- mouse_click(370, 100)
+ # Select Gallery as content source
+ mouse_click(460, 80)
Hint: The full diffs are also available in the runner logs with slightly better highlighting.
nixpkgs-ci
bot
added
10.rebuild-linux: 1-10
Member
Author
|
|
OPNA2608
reviewed
Sep 2, 2025
| # Select Morph as content source | ||
| mouse_click(370, 100) | ||
| # Select Gallery as content source | ||
| mouse_click(460, 80) |
Contributor
There was a problem hiding this comment.
Test is likely failing because this click is missing its target. Please figure out a working coordinate to put here, by launching the test interactively.
The coordinates need to be different here than on master because the version of Lomiri on the stable branch is lacking a commit that changes how the mouse tracks its position on the screen.
Member
Author
|
I don't think I can get this working in a timely manner: the test ends up quite flakey, sometimes for reasons seemingly related to my changes, sometimes not. Closing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Manual backport of #436723 to
release-25.05.