Skip to content

boehmgc: Fix support for multiple flags in CFLAGS_EXTRAS#441438

Merged
philiptaron merged 1 commit intoNixOS:stagingfrom
OPNA2608:fix/boehmgc-CFLAGS_EXTRAS-multiple-flags
Sep 11, 2025
Merged

boehmgc: Fix support for multiple flags in CFLAGS_EXTRAS#441438
philiptaron merged 1 commit intoNixOS:stagingfrom
OPNA2608:fix/boehmgc-CFLAGS_EXTRAS-multiple-flags

Conversation

@OPNA2608
Copy link
Contributor

@OPNA2608 OPNA2608 commented Sep 9, 2025

Addresses the issue commented on in #439943 (review).

Fixes building the boehmgc that Nix needs for POWER. For example, pkgsCross.powernv.nixVersions.nix_2_28.passthru.boehmgc

Things done

  • Built on platform:
    • x86_64-linux
    • powerpc64-linux (cross, ELFv1, via pkgsCross.ppc64-elfv1.nixVersions.nix_2_28.passthru.boehmgc)
    • powerpc64le-linux (cross, via pkgsCross.powernv.nixVersions.nix_2_28.passthru.boehmgc)
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

@OPNA2608 OPNA2608 requested a review from philiptaron September 9, 2025 11:38
@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 5001+ This PR causes many rebuilds on Darwin and must target the staging branches. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches. labels Sep 9, 2025
@OPNA2608 OPNA2608 force-pushed the fix/boehmgc-CFLAGS_EXTRAS-multiple-flags branch from e3f582b to c71f00c Compare September 9, 2025 11:46
@OPNA2608 OPNA2608 changed the base branch from master to staging September 9, 2025 11:46
@nixpkgs-ci nixpkgs-ci bot closed this Sep 9, 2025
@nixpkgs-ci nixpkgs-ci bot reopened this Sep 9, 2025
@OPNA2608
Copy link
Contributor Author

OPNA2608 commented Sep 9, 2025 •
edited
Loading

@ofborg build pkgsCross.powernv.nixVersions.nix_2_28.passthru.boehmgc

philiptaron
philiptaron approved these changes Sep 10, 2025
View reviewed changes
Copy link
Contributor

@philiptaron philiptaron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll test this when I get home, but this looks right to me. Could use appendToVar instead of raw bash.

@nixpkgs-ci nixpkgs-ci bot added the 12.approvals: 1 This PR was reviewed and approved by one person. label Sep 10, 2025
@ConnorBaker
Copy link
Contributor

ConnorBaker commented Sep 11, 2025

Would you be able to try keeping makeFlags and enabling __structuredAttrs instead to see if that works?

@OPNA2608
boehmgc: Enable __structuredAttrs
a8e9468 
So makeFlags values with spaces work correctly (building Nix' boehmgc for POWER).
@OPNA2608 OPNA2608 force-pushed the fix/boehmgc-CFLAGS_EXTRAS-multiple-flags branch from c71f00c to a8e9468 Compare September 11, 2025 13:11
@OPNA2608
Copy link
Contributor Author

OPNA2608 commented Sep 11, 2025

Would you be able to try keeping makeFlags and enabling __structuredAttrs instead to see if that works?

Works, switched to that instead.

@ConnorBaker
Copy link
Contributor

ConnorBaker commented Sep 11, 2025

Anything else need to be done before meeting?

@nixpkgs-ci nixpkgs-ci bot added 12.approvals: 2 This PR was reviewed and approved by two persons. and removed 12.approvals: 1 This PR was reviewed and approved by one person. labels Sep 11, 2025
@philiptaron philiptaron merged commit 7b836bf into NixOS:staging Sep 11, 2025
32 of 36 checks passed
@OPNA2608 OPNA2608 mentioned this pull request Sep 17, 2025
Merged
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@philiptaron philiptaron philiptaron approved these changes

@ConnorBaker ConnorBaker ConnorBaker approved these changes

Assignees

No one assigned

Labels

10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 5001+ This PR causes many rebuilds on Darwin and must target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches. 12.approvals: 2 This PR was reviewed and approved by two persons.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@OPNA2608 @ConnorBaker @philiptaron