nixDependencies: use override only#439943
Merged
roberth merged 6 commits intoNixOS:masterfrom Sep 6, 2025
Merged
Conversation
Undoubtedly many ways to do this.
The hash hasn't changed.
This was referenced Sep 3, 2025
nixpkgs-ci
bot
added
10.rebuild-linux: 101-500
nix-owners
bot
requested review from
Ericson2314,
Mic92,
RaitoBezarius,
edolstra,
roberth,
tomberek and
xokdvium
Contributor
|
Just tested this with my config: eval and build succeeded. Without this change eval fails due to the NIX_CFLAGS_COMPILE conflict with env.NIX_CFLAGS_COMPILE. |
OPNA2608
reviewed
Sep 9, 2025
15 tasks
13 tasks
philiptaron
added a commit
to philiptaron/nixpkgs
that referenced
this pull request
Sep 11, 2025
This resolves the issue reported in NixOS#439943 (comment)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As reported in #437584 (comment), setting
NIX_CFLAGS_COMPILEin anoverrideAttrshas consequences which can cause the derivation to fail to evaluate on some systems.See #421201 for more commentary on avoiding
overrideAttrsin Nixpkgs.What this PR does is introduce override flags to
boehmgcandaws-sdk-cppfor the desired customizations. Inboehmgc, rather than using theNIX_CFLAGS_COMPILEbrutal instrument, we use the existingCFLAGS_EXTRAMakefile option.I also noticed that the
boehmgcmaster repository has been moved (no hash changes) so that's updated as well.Things done
passthru.tests.nixpkgs-reviewon this PR. See nixpkgs-review usage../result/bin/.Add a 👍 reaction to pull requests you find important.