Skip to content

zstd: set meta.pkgConfigModules #436445

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
roberth merged 1 commit into from
Aug 27, 2025
Merged

zstd: set meta.pkgConfigModules #436445

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions pkgs/tools/compression/zstd/default.nix
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,8 @@
curl,
python3Packages,
haskellPackages,
testers,
zstd,
}:

stdenv.mkDerivation rec {
Expand Down Expand Up @@ -126,6 +128,7 @@ stdenv.mkDerivation rec {
python-zstd = python3Packages.zstd;
haskell-zstd = haskellPackages.zstd;
haskell-hs-zstd = haskellPackages.hs-zstd;
pkg-config = testers.hasPkgConfigModules { package = zstd; };
Copy link
Contributor

@wolfgangwalther wolfgangwalther Aug 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same argument as in https://github.com/NixOS/nixpkgs/pull/436468/files#r2296679493, I think we should at least do the right thing for this test.

Copy link
Member

@roberth roberth Aug 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

};
};

Expand All @@ -146,5 +149,6 @@ stdenv.mkDerivation rec {
mainProgram = "zstd";
platforms = platforms.all;
maintainers = with maintainers; [ orivej ];
pkgConfigModules = [ "libzstd" ];
};
}
Loading