zstd: set meta.pkgConfigModules#436445
Merged
roberth merged 1 commit intoNixOS:masterfrom Aug 27, 2025
Merged
Conversation
I've chosen to use zstd from the pkgs fix point for the pkg-config test instead of using finalAttrs.finalPackage because this is effectively also done for all the other tests (they test bindings from the pkgs fix point which get their zstd from the pkgs fix point).
nixpkgs-ci
bot
added
10.rebuild-linux: 11-100
Contributor
|
Member
Author
Indeed, didn't actually try. Seems like these just show up one by one how wonderful. |
Member
Author
|
@wolfgangwalther just needs #436468 |
| python-zstd = python3Packages.zstd; | ||
| haskell-zstd = haskellPackages.zstd; | ||
| haskell-hs-zstd = haskellPackages.hs-zstd; | ||
| pkg-config = testers.hasPkgConfigModules { package = zstd; }; |
Contributor
There was a problem hiding this comment.
Same argument as in https://github.com/NixOS/nixpkgs/pull/436468/files#r2296679493, I think we should at least do the right thing for this test.
Member
There was a problem hiding this comment.
Member
These tests serve different roles. The reverse dependencies test the package set, whereas this should be a test for an intrinsic property of the package. If we can include overrides in the test, we should make it coherent like that. I'll merge this to unblock you, but this isn't quite right yet. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've chosen to use zstd from the pkgs fix point for the pkg-config test instead of using finalAttrs.finalPackage because this is effectively also done for all the other tests (they test bindings from the pkgs fix point which get their zstd from the pkgs fix point).
This will fix this regression on haskell-updates (since buildInputs is built based on
meta.pkgConfigModules(long story)).Things done
passthru.tests.nixpkgs-reviewon this PR. See nixpkgs-review usage../result/bin/.Add a 👍 reaction to pull requests you find important.