moar: 1.33.0 -> 2.6.1, rename to moor, modernize

[getchoo]

Diff: walles/moor@v1.33.0...v2.6.1
Changelog: https://github.com/walles/moor/releases/tag/v2.6.1

Things done

• Built on platform:
  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
• Tested, as applicable:
  • NixOS tests in nixos/tests.
  • Package tests at passthru.tests.
  • Tests in lib/tests or pkgs/test for functions and "core" functionality.
• Ran nixpkgs-review on this PR. See nixpkgs-review usage.
• Tested basic functionality of all binary files, usually in ./result/bin/.
• Nixpkgs Release Notes
  • Package update: when the change is major or breaking.
• NixOS Release Notes
  • Module addition: when adding a new NixOS module.
  • Module update: when the change is significant.
• Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

---

Add a 👍 reaction to pull requests you find important.

[RossSmyth]

I have been told not to use pkgsCross within package definitions, even within passthru tests.

[getchoo]

This is the first time I'm really hearing of that

I'm not exactly sure why we shouldn't either. There's the evaluation performance penalty obviously, but this is only being run in OfBorg for one package. I believe that should be fine?

I'd also question how else we're supposed to ensure cross builds for packages still work without pkgsCross. Even in the code that was finally merged with that PR for example, nixosTests.wine still uses it. Cross build regressions are super common in PRs, so this would definitely be a hole that needs to be filled

If there's something I'm missing here and this is a bigger issue, I'd really recommend documenting it @Ericson2314

[Ericson2314]

I'll defer to @alyssais on this. I don't get why we cannot just run pkgsCross.aarch64-multiplatform.moor.tests, test all packages cross compiled. Forcing cross tests for some packages feels ad hoc to me.

[alyssais]

I think it's basically harmless in passthru.tests. Eventually, it would be nice to make pkgsCross not visible inside packages, but I don't see this as a blocker because we can have some other stage where we add cross tests to packages that need it. Even if we had a way to automatically a cross test build on every package in OfBorg, we'd still need a way to mark which packages were expected to work.

[Ericson2314]

OK, sounds good!

[RossSmyth]

Yes, I do not know what the issue is, and I also agree that I do not know how else to ensure cross builds are tested, and I am also aware that the Wine tests use it internally. Aug 22, 2025 00:16:35 Seth Flynn ***@***.***>:

…

***@***.**** commented on this pull request. ---------------------------------------- In pkgs/by-name/mo/moor/package.nix[#435670 (comment)]: > + ldflags = [ + "-s" + "-w" + "-X" + "main.versionString=v${finalAttrs.version}" + ]; + + nativeInstallCheckInputs = [ versionCheckHook ]; + doInstallCheck = true; + + postInstall = '' + installManPage ./moor.1 + ''; + + passthru = { + tests.cross-aarch64 = pkgsCross.aarch64-multiplatform.moor; This is the first time I'm really hearing of that I'm not exactly sure /why/ we shouldn't either. There's the evaluation performance penalty obviously, but this is only being run in OfBorg for one package. I believe that should be fine? I'd also question how else we're supposed to ensure cross builds for packages still work without *pkgsCross*. Even in the code that was finally merged with that PR for example, *nixosTests.wine* still uses it[https://github.com/NixOS/nixpkgs/blob/185acc48e87bc64c59926668f13c3ba62e48c564/nixos/tests/wine.nix#L18-L19]. Cross build regressions are /super/ common in PRs, so this would definitely be a hole that needs to be filled If there's something I'm missing here and this is a bigger issue, I'd really recommend documenting it @Ericson2314[https://github.com/Ericson2314] — Reply to this email directly, view it on GitHub[#435670 (comment)], or unsubscribe[https://github.com/notifications/unsubscribe-auth/AELSM7OU2CZMFGRHFTOKRRD3O2KSHAVCNFSM6AAAAACEP6FJJKVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZTCNBTGAYTSNBXGA]. You are receiving this because you commented. [Tracking image][https://github.com/notifications/beacon/AELSM7IYBPWJX7HQAFUBSTL3O2KSHA5CNFSM6AAAAACEP6FJJKWGG33NNVSW45C7OR4XAZNRKB2WY3CSMVYXKZLTORJGK5TJMV32UY3PNVWWK3TUL5UWJTV3K2V44.gif]

[boomshroom]

Since this PR was made, another update was released fixing a crash.

[nekowinston]

Would appreciate it if this could get merged, thanks for the update 🙂

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 435670
Commit: 53ca24c47c59cb2e2c3cedef63112751e162c8d5

---

x86_64-linux

⏩ 1 package blacklisted:

• tests.nixos-functions.nixos-test

✅ 2 packages built:

• moor
• nixpkgs-manual