windows.mingw_w64: 12.0.0 -> 13.0.0#430515
Conversation
puffnfresh
left a comment
There was a problem hiding this comment.
Looks good. I like the Nu shell update script.
|
I find nushell to be quite good for updateScripts because it is good at extracting things from structured data. |
|
We shouldn't be using |
The primary consumer of this in nixpkgs is Wine, which definitely uses pkgsCross. How else are we supposed to cross compile? |
|
Besides just saying "no" without any alternative, how should I do about testing this? |
|
treefmt failed on a completely unrelated file |
|
It has been merged, rebase your pr and it should be fixed. |
|
It looks like you changed the test now, but I was thinking that you could simply have the test use the current package set, and if you didn't pull tests from this package in a host=mingw package set they would fail to eval because unsupported system. |
|
I attempted to build the wine tests on my computer, but I just killed the build after 12 hours. Just building wine serially is fine, but I guess when it builds like four or five concurrently the scheduler can't handle it well. |
Things done
I ran the test on my computer and it was fine.
passthru.tests.nixpkgs-reviewon this PR. See nixpkgs-review usage../result/bin/.Add a 👍 reaction to pull requests you find important.