Skip to content

windows.mingw_w64: 12.0.0 -> 13.0.0#430515

Merged
Ericson2314 merged 2 commits intoNixOS:masterfrom
RossSmyth:mingwBump
Aug 7, 2025
Merged

windows.mingw_w64: 12.0.0 -> 13.0.0#430515
Ericson2314 merged 2 commits intoNixOS:masterfrom
RossSmyth:mingwBump

Conversation

@RossSmyth
Copy link
Contributor

Things done

  1. Add updateScript
  2. Add passthru test
  3. Update mingw

I ran the test on my computer and it was fine.

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux. 10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. 6.topic: windows Running, or buiding, packages on Windows labels Aug 3, 2025
Copy link
Member

@puffnfresh puffnfresh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I like the Nu shell update script.

@RossSmyth
Copy link
Contributor Author

I find nushell to be quite good for updateScripts because it is good at extracting things from structured data.

@nixpkgs-ci nixpkgs-ci bot added the 12.approvals: 1 This PR was reviewed and approved by one person. label Aug 3, 2025
@Ericson2314
Copy link
Member

Ericson2314 commented Aug 3, 2025

We shouldn't be using pkgsCross in packages, even for tests. Otherwise looks good though.

Copy link
Member

@Ericson2314 Ericson2314 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comment

@RossSmyth
Copy link
Contributor Author

We shouldn't be using pkgsCross in packages, even for tests. Otherwise looks good though.

The primary consumer of this in nixpkgs is Wine, which definitely uses pkgsCross. How else are we supposed to cross compile?

@RossSmyth
Copy link
Contributor Author

Besides just saying "no" without any alternative, how should I do about testing this?

@RossSmyth
Copy link
Contributor Author

treefmt failed on a completely unrelated file

@RossSmyth
Copy link
Contributor Author

#430675

@Eveeifyeve
Copy link
Member

It has been merged, rebase your pr and it should be fixed.

@Ericson2314
Copy link
Member

It looks like you changed the test now, but I was thinking that you could simply have the test use the current package set, and if you didn't pull tests from this package in a host=mingw package set they would fail to eval because unsupported system.

@RossSmyth
Copy link
Contributor Author

I attempted to build the wine tests on my computer, but I just killed the build after 12 hours. Just building wine serially is fine, but I guess when it builds like four or five concurrently the scheduler can't handle it well.

@Ericson2314 Ericson2314 enabled auto-merge August 7, 2025 19:27
@Ericson2314 Ericson2314 merged commit 32bfc37 into NixOS:master Aug 7, 2025
25 of 27 checks passed
@RossSmyth RossSmyth deleted the mingwBump branch August 11, 2025 20:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: windows Running, or buiding, packages on Windows 10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux. 12.approvals: 1 This PR was reviewed and approved by one person.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants