Skip to content

victoriametrics: 1.123.0 -> 1.124.0 #434803

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
leona-ya merged 1 commit into from
Aug 22, 2025
Merged

victoriametrics: 1.123.0 -> 1.124.0 #434803

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions pkgs/by-name/vi/victoriametrics/package.nix
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,13 +13,13 @@

buildGoModule (finalAttrs: {
pname = "VictoriaMetrics";
version = "1.123.0";
version = "1.124.0";

src = fetchFromGitHub {
owner = "VictoriaMetrics";
repo = "VictoriaMetrics";
tag = "v${finalAttrs.version}";
hash = "sha256-GUVRMlF94BaZSVfz4Z+IBSpf6WuA5o1WQQmeZAqKZ1g=";
hash = "sha256-f0Mf/4cFnJ/3I8z/4UhhNJnSCau9Q7mFfR32lP9/yi0=";
};

vendorHash = null;
Expand Down Expand Up @@ -51,6 +51,10 @@ buildGoModule (finalAttrs: {
# This appears to be some kind of test server for development purposes only.
rm -f app/vmui/packages/vmui/web/{go.mod,main.go}

# Allow older go versions
substituteInPlace go.mod \
--replace-fail "go 1.24.6" "go ${finalAttrs.passthru.go.version}"
Comment on lines +54 to +56
Copy link
Contributor

@Shawn8901 Shawn8901 Aug 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI: The go bump from 1.24.5 to 1.24.6 is currently included on staging-next.

Copy link
Contributor

@r-vdp r-vdp Aug 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we wait for that then and update this PR once -next is merged? Otherwise this will fail to build after the -next merge.

Copy link
Contributor

@Shawn8901 Shawn8901 Aug 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On the last staging cycle we merged victoria-metrics/-logs bumps to staging-next.
I have no hard opinions on that topic if we should merge to staging-next and drop this, or merge to master and drop it if the have the go bump, or keep it at all and update it with every tool chain bump from upstream.

My intention here was just to let people know that the tool chain bump is currently sitting on the current staging cycle and waits for regression fixes (on other topics)

Copy link
Member

@leona-ya leona-ya Aug 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's fine IMO. grafana does something similar and we're not bound to staging-next cycles which annoys me tbh.

I tested that

    substituteInPlace go.mod \
      --replace-fail "go 1.24.5" "go 1.24.5"

works too.


# Increase timeouts in tests to prevent failure on heavily loaded builders
substituteInPlace lib/storage/storage_test.go \
--replace-fail "time.After(10 " "time.After(120 " \
Expand Down
Loading