Skip to content

victoriametrics: 1.123.0 -> 1.124.0#434803

Merged
leona-ya merged 1 commit intoNixOS:masterfrom
transcaffeine:victoriametrics/1.124.0
Aug 22, 2025
Merged

victoriametrics: 1.123.0 -> 1.124.0#434803
leona-ya merged 1 commit intoNixOS:masterfrom
transcaffeine:victoriametrics/1.124.0

Conversation

@transcaffeine
Copy link
Member

@transcaffeine transcaffeine commented Aug 18, 2025 •
edited
Loading

Release notes: https://github.com/VictoriaMetrics/VictoriaMetrics/releases/tag/v1.124.0
Full changelog: VictoriaMetrics/VictoriaMetrics@v1.123.0...v1.124.0

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. labels Aug 18, 2025
@transcaffeine transcaffeine marked this pull request as ready for review August 18, 2025 19:49
ryan4yin
ryan4yin approved these changes Aug 19, 2025
View reviewed changes
Copy link
Member

@ryan4yin ryan4yin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 434803 --package victoriametrics.passthru.tests
Commit: 30db5ac53228dace25ce1a55ca179dc608eabbac

x86_64-linux

✅ 3 packages built:
  • victoriametrics.passthru.tests.victoriametrics.external-promscrape-config
  • victoriametrics.passthru.tests.victoriametrics.remote-write
  • victoriametrics.passthru.tests.victoriametrics.vmalert

@nixpkgs-ci nixpkgs-ci bot added 12.approvals: 1 This PR was reviewed and approved by one person. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages. labels Aug 19, 2025
Shawn8901
Shawn8901 approved these changes Aug 19, 2025
View reviewed changes
Copy link
Contributor

@Shawn8901 Shawn8901 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on my aarch64 that runs a victoriametrics and vmagent setup

pkgs/by-name/vi/victoriametrics/package.nix
Comment on lines +54 to +56
# Allow older go versions
substituteInPlace go.mod \
--replace-fail "go 1.24.6" "go ${finalAttrs.passthru.go.version}"
Copy link
Contributor

@Shawn8901 Shawn8901 Aug 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI: The go bump from 1.24.5 to 1.24.6 is currently included on staging-next.

Copy link
Contributor

@r-vdp r-vdp Aug 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we wait for that then and update this PR once -next is merged? Otherwise this will fail to build after the -next merge.

Copy link
Contributor

@Shawn8901 Shawn8901 Aug 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On the last staging cycle we merged victoria-metrics/-logs bumps to staging-next.
I have no hard opinions on that topic if we should merge to staging-next and drop this, or merge to master and drop it if the have the go bump, or keep it at all and update it with every tool chain bump from upstream.

My intention here was just to let people know that the tool chain bump is currently sitting on the current staging cycle and waits for regression fixes (on other topics)

Copy link
Member

@leona-ya leona-ya Aug 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's fine IMO. grafana does something similar and we're not bound to staging-next cycles which annoys me tbh.

I tested that

    substituteInPlace go.mod \
      --replace-fail "go 1.24.5" "go 1.24.5"

works too.

@nixpkgs-ci nixpkgs-ci bot added 12.approvals: 2 This PR was reviewed and approved by two persons. and removed 12.approvals: 1 This PR was reviewed and approved by one person. labels Aug 19, 2025
@leona-ya leona-ya merged commit 0c5755b into NixOS:master Aug 22, 2025
35 of 37 checks passed
@Shawn8901 Shawn8901 mentioned this pull request Aug 24, 2025
Merged
13 tasks
@transcaffeine transcaffeine mentioned this pull request Oct 10, 2025
Merged
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@r-vdp r-vdp r-vdp left review comments

@leona-ya leona-ya leona-ya approved these changes

@ivan ivan Awaiting requested review from ivan

@yorickvP yorickvP Awaiting requested review from yorickvP

+2 more reviewers

@Shawn8901 Shawn8901 Shawn8901 approved these changes

@ryan4yin ryan4yin ryan4yin approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 12.approvals: 2 This PR was reviewed and approved by two persons. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@transcaffeine @r-vdp @leona-ya @Shawn8901 @ryan4yin