sgx-sdk: unpin GCC #434553
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,13 +1,13 @@ | ||
| { | ||
| stdenv, | ||
| fetchFromGitHub, | ||
| cmake, | ||
| nasm, | ||
| openssl, | ||
| python3, | ||
| extraCmakeFlags ? [ ], | ||
| }: | ||
| stdenv.mkDerivation rec { | ||
| pname = "ipp-crypto"; | ||
| version = "2021.11.1"; | ||
|
|
||
|
|
@@ -25,6 +25,12 @@ gcc11Stdenv.mkDerivation rec { | |
| ] | ||
| ++ extraCmakeFlags; | ||
|
|
||
| # Yes, it seems bad for a cryptography library to trigger this | ||
| # warning. We previously pinned an EOL GCC which avoided it, but this | ||
| # issue is present regardless of whether we use a compiler that flags | ||
| # it up or not; upstream just doesn’t test with modern compilers. | ||
| env.NIX_CFLAGS_COMPILE = "-Wno-error=stringop-overflow"; | ||
|
Comment on lines
+28
to
+32
Contributor
There was a problem hiding this comment. Potentially mention this issue, which seems related?
Member
Author
There was a problem hiding this comment. Hmm, that doesn’t seem to include the default‐error warning that breaks the build here, and triggers even without They nominally claim support for GCC 14, though. Go figure. I could report an issue upstream if you want, but the upstream responses are generally not very encouraging. |
||
|
|
||
| nativeBuildInputs = [ | ||
| cmake | ||
| nasm | ||
|
|
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems to be outdated, upstream seems to have changed its tags:
https://github.com/intel/cryptography-primitives/tags
Maybe a newer version builds differently?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tried
HEADand it failed in exactly the same way. This is internal tosgx-sdkand this version more closely matches the version pinned as a submodule in that repository (though it’s actually a patch version bump ahead), so I’m inclined to leave it to thesgx-sdkmaintainers to handle bumping it, given that it doesn’t affect the warning.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, I see. This also explains why there is no meta section, I guess.