Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compilation warnings and error in Release mode #73

Open
hector-cao opened this issue Feb 21, 2024 · 3 comments
Open

Compilation warnings and error in Release mode #73

hector-cao opened this issue Feb 21, 2024 · 3 comments
Assignees
Labels
enhancement New feature or request

Comments

@hector-cao
Copy link

hector-cao commented Feb 21, 2024

When I enable -Wall and build ipp-crypto in Release mode, there are a bunch of build warnings and warnings are treated as errors that make my compilation failed.

$ gcc --version
gcc (Ubuntu 13.2.0-13ubuntu1) 13.2.0
Copyright (C) 2023 Free Software Foundation, Inc.
This is free software; see the source for copying conditions. There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.

Here is the cmake command:

cmake ./ -DARCH=intel64 -DCMAKE_BUILD_TYPE=Release -DCMAKE_C_FLAGS="-Wall "

To remove all warnings, i need to add following flags:

                             -Wno-unused-function -Wno-unused-variable \                                                         
                             -Wno-unused-but-set-variable \                                                                      
                             -Wno-pedantic -Wno-comment \                                                                        
                             -Wno-array-parameter -Wno-strict-aliasing \                                                         
                             -Wno-parentheses -Wno-unknown-pragmas \                                                             
                             -Wno-missing-braces

I m wondering if some of those warnings can be easily fixed ?

@paveldyakov
Copy link

Hi @hector-cao,

Thank you for reporting the issue!
I was able to reproduce the mentioned behavior.

Could you please tell if -Wall flag is important for your application?
Mentioned warnings are not critical and should not affect the functionality correctness.

@hector-cao
Copy link
Author

Hello @paveldyakov , thanks for your feedback,

-Wall is not essential, but i think this is a good opportunity to fix some of warnings, especially for the ones that are trivial and obvious.

@paveldyakov
Copy link

@hector-cao,
Glad to hear that it doesn't block you.
And I definitely agree with you - we will add "-Wall" enabling in our future plans

@paveldyakov paveldyakov self-assigned this Feb 22, 2024
@paveldyakov paveldyakov added the enhancement New feature or request label Feb 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants