-
-
Notifications
You must be signed in to change notification settings - Fork 19.7k
home-assistant: 2025.8.0 -> 2025.8.1 #432915
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 6 commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
5e2ab86
python3Packages.airos: 0.2.4 -> 0.2.7
mweinelt fa327fb
python3Packages.hass-nabucasa: 0.111.1 -> 0.111.2
mweinelt a6feaea
python3Packages.knx-frontend: 2025.8.6.52906 -> 2025.8.9.63154
mweinelt 3b36b3c
python3Packages.zha-quirks: 0.0.142 -> 0.0.143
mweinelt 23e5a85
python3Packages.zha: 0.0.66 -> 0.0.68
mweinelt cde65a8
home-assistant: 2025.8.0 -> 2025.8.1
mweinelt 2bf2fc2
python3Packages.homeassistant-stubs: 2025.8.0 -> 2025.8.1
mweinelt 9108b8e
home-assistant.python.pkgs.pytest-homeassistant-custom-component: 0.1…
mweinelt 3caf079
home-assistant: pin python-roborock at 2.18.2
mweinelt File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nixfmtwas removed on purpose from update scripts' shebangs in b68cc63. This is expected to be available via nixpkgs' nix-shell environment / treefmt configuration instead.Removed again in #433588.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It did not find nixfmt, when I ran it. That's why I added it back. I'm not manually attaching to the shell in the repo root, if that's what you're asking.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unfortunately, that's what we need to expect, though. You'd either need to enter
nix-shellmanually or havedirenvset up.That's because
nixfmtonly works by accident, because it doesn't have configuration (right now). As soon as we have configuration for it, which happens via treefmt-nix, anixfmt(ornixfmt-rfc-style) that you get directly from whatever nixpkgs this update script takes packages from... it would result in different formatting results.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe... you can replace
nixfmtwithnix fmt? This should also work outside nix-shell, although only with the new CLI. So maybe with the enable-experimental-features flag?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
whats' the reason for letting everyone do this on their own instead of adding it to nixpkgs directly?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know. There is #325793 which added the file to .gitignore. I didn't read through it, but it refers to some other issues / PRs.. I assume this would have been controversial? Dunno.
I think it should really be set up by default. It's annoying to have to do it manually. If you're not running direnv, it won't bother you anyway.