home-assistant: 2025.8.0 -> 2025.8.1#432915
Merged
Conversation
nixpkgs-ci
bot
added
10.rebuild-linux: 501+
nix-owners
bot
requested review from
JamieMagee,
Scriptkiddi,
dotlambda and
fabaff
Member
Author
|
JamieMagee
approved these changes
Aug 12, 2025
nixpkgs-ci
bot
added
12.approvals: 1
Member
|
| @@ -1,5 +1,5 @@ | |||
| #! /usr/bin/env nix-shell | |||
| #! nix-shell -i python3 -p "python3.withPackages (ps: with ps; [ packaging rich ])" -p pyright ruff isort | |||
| #! nix-shell -i python3 -p "python3.withPackages (ps: with ps; [ packaging rich ])" -p pyright ruff isort nixfmt | |||
Contributor
Member
Author
There was a problem hiding this comment.
It did not find nixfmt, when I ran it. That's why I added it back. I'm not manually attaching to the shell in the repo root, if that's what you're asking.
Contributor
There was a problem hiding this comment.
I'm not manually attaching to the shell in the repo root, if that's what you're asking.
Unfortunately, that's what we need to expect, though. You'd either need to enter nix-shell manually or have direnv set up.
That's because nixfmt only works by accident, because it doesn't have configuration (right now). As soon as we have configuration for it, which happens via treefmt-nix, a nixfmt (or nixfmt-rfc-style) that you get directly from whatever nixpkgs this update script takes packages from... it would result in different formatting results.
Contributor
There was a problem hiding this comment.
Maybe... you can replace nixfmt with nix fmt? This should also work outside nix-shell, although only with the new CLI. So maybe with the enable-experimental-features flag?
Member
There was a problem hiding this comment.
or have direnv set up.
whats' the reason for letting everyone do this on their own instead of adding it to nixpkgs directly?
Contributor
There was a problem hiding this comment.
I don't know. There is #325793 which added the file to .gitignore. I didn't read through it, but it refers to some other issues / PRs.. I assume this would have been controversial? Dunno.
I think it should really be set up by default. It's annoying to have to do it manually. If you're not running direnv, it won't bother you anyway.
This was referenced Aug 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Things done
passthru.tests.nixpkgs-reviewon this PR. See nixpkgs-review usage../result/bin/.Add a 👍 reaction to pull requests you find important.