Skip to content

mtkclient: init at 2.0.1-unstable-2025-09-26#432318

Merged
SuperSandro2000 merged 1 commit intoNixOS:masterfrom
timschumi:mtkclient-2.0.2
Nov 1, 2025
Merged

mtkclient: init at 2.0.1-unstable-2025-09-26#432318
SuperSandro2000 merged 1 commit intoNixOS:masterfrom
timschumi:mtkclient-2.0.2

Conversation

@timschumi
Copy link
Member

@timschumi timschumi commented Aug 9, 2025 •
edited
Loading

mtkclient is a low-level tool to interface with Mediatek-based devices while in brom or preloader mode.

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 9.needs: reviewer This PR currently has no reviewers requested and needs attention. labels Aug 9, 2025
yzhou216
yzhou216 reviewed Aug 12, 2025
View reviewed changes
@nixpkgs-ci nixpkgs-ci bot removed the 9.needs: reviewer This PR currently has no reviewers requested and needs attention. label Aug 12, 2025
@timschumi timschumi changed the title mtkclient: init at 2.0.2 mtkclient: init at 0-unstable-2025-06-08 Aug 17, 2025
yzhou216
yzhou216 suggested changes Aug 17, 2025
View reviewed changes
@yzhou216
Copy link
Contributor

yzhou216 commented Aug 17, 2025

nixpkgs-review result

Generated using nixpkgs-review-gha

Command: nixpkgs-review pr 432318

Logs: https://github.com/yzhou216/nixpkgs-review-gha/actions/runs/17025965633

Download packages from cache:
  • x86_64-linux 
    nix-store -r --add-root nixpkgs-pr-432318-x86_64-linux \
  --option binary-caches 'https://cache.nixos.org/ https://yzhou216.cachix.org' \
  --option trusted-public-keys '
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  yzhou216.cachix.org-1:O7nGwQnLGGBGE8zYFMipVzPVN956FcV57y9SqwEP+O8=
  ' \
  /nix/store/lq2rb0m326r6yfny9b35k2k58kd1llfh-mtkclient-0-unstable-2025-06-08 \
  /nix/store/f2ynzrc957hcjxybqabfi41h6xcpfcal-mtkclient-0-unstable-2025-06-08-dist
  • aarch64-linux 
    nix-store -r --add-root nixpkgs-pr-432318-aarch64-linux \
  --option binary-caches 'https://cache.nixos.org/ https://yzhou216.cachix.org' \
  --option trusted-public-keys '
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  yzhou216.cachix.org-1:O7nGwQnLGGBGE8zYFMipVzPVN956FcV57y9SqwEP+O8=
  ' \
  /nix/store/ylf6l7nf6l6xmr8mzpny0wahqdczj78q-mtkclient-0-unstable-2025-06-08 \
  /nix/store/z4wl4s99kjlfzarnc37x6wr2nzmdpb78-mtkclient-0-unstable-2025-06-08-dist
  • x86_64-darwin 
    nix-store -r --add-root nixpkgs-pr-432318-x86_64-darwin \
  --option binary-caches 'https://cache.nixos.org/ https://yzhou216.cachix.org' \
  --option trusted-public-keys '
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  yzhou216.cachix.org-1:O7nGwQnLGGBGE8zYFMipVzPVN956FcV57y9SqwEP+O8=
  ' \
  /nix/store/0fd49s2wwgn4yg8fbsfldg7h922i0dhx-mtkclient-0-unstable-2025-06-08 \
  /nix/store/is0izrckknyl9q00jfwzfppqd4lsa93m-mtkclient-0-unstable-2025-06-08-dist
  • aarch64-darwin 
    nix-store -r --add-root nixpkgs-pr-432318-aarch64-darwin \
  --option binary-caches 'https://cache.nixos.org/ https://yzhou216.cachix.org' \
  --option trusted-public-keys '
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  yzhou216.cachix.org-1:O7nGwQnLGGBGE8zYFMipVzPVN956FcV57y9SqwEP+O8=
  ' \
  /nix/store/n8sgg5vbf5zjj51bpqgx3shqnhrbhhr4-mtkclient-0-unstable-2025-06-08 \
  /nix/store/wyakcm5ksyvg2l5lr9kzss3mjvl4zmr2-mtkclient-0-unstable-2025-06-08-dist

x86_64-linux

✅ 2 packages built:
  • mtkclient
  • mtkclient.dist

aarch64-linux

✅ 2 packages built:
  • mtkclient
  • mtkclient.dist

x86_64-darwin (sandbox = true)

✅ 2 packages built:
  • mtkclient
  • mtkclient.dist

aarch64-darwin (sandbox = true)

✅ 2 packages built:
  • mtkclient
  • mtkclient.dist

yzhou216
yzhou216 approved these changes Aug 17, 2025
View reviewed changes
Copy link
Contributor

@yzhou216 yzhou216 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved automatically following the successful run of nixpkgs-review.

@nixpkgs-ci nixpkgs-ci bot added the 12.approvals: 1 This PR was reviewed and approved by one person. label Aug 17, 2025
SuperSandro2000
SuperSandro2000 reviewed Sep 8, 2025
View reviewed changes
@timschumi timschumi changed the title mtkclient: init at 0-unstable-2025-06-08 mtkclient: init at 0-unstable-2025-09-10 Sep 20, 2025
@timschumi timschumi changed the title mtkclient: init at 0-unstable-2025-09-10 mtkclient: init at 0-unstable-2025-09-26 Sep 27, 2025
@timschumi timschumi mentioned this pull request Oct 14, 2025
Closed
13 tasks
@timschumi
Copy link
Member Author

timschumi commented Oct 16, 2025

Pulled in udev files from #447819 in latest push. 50-android.rules is due to be obsolete with systemd 258, so I'll drop that once #427968 lands in master, and 51-edl.rules probably doesn't do anything at all because it's for qcom.

@shymega I stole the authorship information from 6814394, let me know if you want something else listed there (or nothing at all).

@timschumi timschumi changed the title mtkclient: init at 0-unstable-2025-09-26 mtkclient: init at 2.0.1-unstable-2025-09-26 Oct 16, 2025
@timschumi
Copy link
Member Author

timschumi commented Oct 16, 2025

Also updated the version number to 2.0.1-unstable-..., I think that's what most can agree on and is most in line with the guidelines.

@nixpkgs-ci nixpkgs-ci bot removed 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Oct 16, 2025
@shymega
Copy link
Member

shymega commented Oct 31, 2025

Pulled in udev files from #447819 in latest push. 50-android.rules is due to be obsolete with systemd 258, so I'll drop that once #427968 lands in master, and 51-edl.rules probably doesn't do anything at all because it's for qcom.

@shymega I stole the authorship information from 6814394, let me know if you want something else listed there (or nothing at all).

@timschumi You mean the meta attrset? You didn't specify a line range in the link, so I wasn't sure.

@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Oct 31, 2025
@timschumi
Copy link
Member Author

timschumi commented Oct 31, 2025

You mean the meta attrset? You didn't specify a line range in the link, so I wasn't sure.

What I'm talking about is the Co-authored-by line in the commit message. I copied your name and email from the authorship information of the referenced commit.

@shymega
Copy link
Member

shymega commented Oct 31, 2025

You mean the meta attrset? You didn't specify a line range in the link, so I wasn't sure.

What I'm talking about is the Co-authored-by line in the commit message. I copied your name and email from the authorship information of the referenced commit.

Oh, right. Yeah, that's fine - if you need any help maintaining, I'm happy to be added there if you want. But it's not a hard requirement. Glad my PR could be of help - I'm going to close it soon in favor of this one.

@timschumi @shymega
mtkclient: init at 2.0.1-unstable-2025-09-26
2c40a30 
Co-authored-by: Dom Rodriguez <shymega@shymega.org.uk>
@timschumi
Copy link
Member Author

timschumi commented Oct 31, 2025

Added the proper sourceProvenance definitions in the latest push and dropped the udev rules files in the push before that.

Continuing a remaining point of discussion from #447819 here:

maybe we should keep the udev rules until this version of systemd has been in unstable, 25.05, and the upcoming 25.11 for a few weeks?

Any branch that doesn't have the new systemd version still has android-udev-rules available, which is a more updated version of the 50-android.rules in mtkclient.

@shymega
Copy link
Member

shymega commented Oct 31, 2025

Added the proper sourceProvenance definitions in the latest push and dropped the udev rules files in the push before that.

Nice!

Continuing a remaining point of discussion from #447819 here:

maybe we should keep the udev rules until this version of systemd has been in unstable, 25.05, and the upcoming 25.11 for a few weeks?

Any branch that doesn't have the new systemd version still has android-udev-rules available, which is a more updated version of the 50-android.rules in mtkclient.

Sounds like a good plan, thanks for looking into this.

I'm going to go ahead and approve this PR as its looking good!

shymega
shymega approved these changes Oct 31, 2025
View reviewed changes
Copy link
Member

@shymega shymega left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, and beat me to the punch!

@nixpkgs-ci nixpkgs-ci bot added 12.approvals: 2 This PR was reviewed and approved by two persons. and removed 12.approvals: 1 This PR was reviewed and approved by one person. labels Oct 31, 2025
@SuperSandro2000 SuperSandro2000 added this pull request to the merge queue Nov 1, 2025
Merged via the queue into NixOS:master with commit 47076e9 Nov 1, 2025
29 of 31 checks passed
@timschumi timschumi deleted the mtkclient-2.0.2 branch November 1, 2025 19:47
@shymega
Copy link
Member

shymega commented Nov 1, 2025

@timschumi I've added the backport-release-25.05 label, so that I can update the mtkclient Flake I added to the upstream repo to point to this MR.

@nixpkgs-ci nixpkgs-ci bot mentioned this pull request Nov 1, 2025
Closed
1 task
@nixpkgs-ci
Copy link
Contributor

nixpkgs-ci bot commented Nov 1, 2025

Successfully created backport PR for release-25.05:

@github-actions github-actions bot added the 8.has: port to stable This PR already has a backport to the stable release. label Nov 1, 2025
@shymega shymega mentioned this pull request Dec 4, 2025
Closed
13 tasks
shymega added a commit to shymega/mtkclient that referenced this pull request Dec 4, 2025
@shymega
chore(nix): Update Nixpkgs input now MR has been merged
465e62f 
This will use Nixpkgs Unstable, which should have
NixOS/nixpkgs#432318 in the tree now.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@SuperSandro2000 SuperSandro2000 Awaiting requested review from SuperSandro2000

2 more reviewers

@shymega shymega shymega approved these changes

@yzhou216 yzhou216 yzhou216 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

8.has: port to stable This PR already has a backport to the stable release. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 12.approvals: 2 This PR was reviewed and approved by two persons.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@timschumi @yzhou216 @shymega @SuperSandro2000