Skip to content

github-linguist: fix gem extension build warnings#431923

Merged
Sigmanificient merged 1 commit intoNixOS:masterfrom
abiriadev:github-linguist-fix-warning
Aug 13, 2025
Merged

github-linguist: fix gem extension build warnings#431923
Sigmanificient merged 1 commit intoNixOS:masterfrom
abiriadev:github-linguist-fix-warning

Conversation

@abiriadev
Copy link
Contributor

Let github-linguist use Ruby 3.4, in order to fix #425375.

See also #416427 and #400243.

No breaking changes. version and Gemfile.lock & gemset.nix will be preserved.

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 12.first-time contribution This PR is the author's first one; please be gentle! labels Aug 8, 2025
@nix-owners nix-owners bot requested a review from Cryolitia August 8, 2025 05:03
@abiriadev
Copy link
Contributor Author

To test:

nix run github:nixos/nixpkgs/1277ecfcaa8e6e2226d417781f443c8f6deaf55b#github-linguist -- --help

It shouldn't print any warnings for missing extensions.

Linguist v9.1.0
Detect language type and determine language breakdown for a given Git repository.

Usage: linguist <path>
       linguist <path> [--rev REV] [--tree-size] [--breakdown] [--json]
       linguist [--rev REV] [--tree-size] [--breakdown] [--json]
    -b, --breakdown                  Analyze entire repository and display detailed usage statistics
    -j, --json                       Output results as JSON
    -r, --rev REV                    Analyze specific git revision
                                     defaults to HEAD, see gitrevisions(1) for alternatives
    -t, --tree-size=NUMBER           Maximum number of files scanned to detect languages (default: 100000)
    -h, --help                       Display a short usage summary, then exit

@acid-bong
Copy link
Contributor

nixpkgs-review result

Generated using nixpkgs-review-gha

Command: nixpkgs-review pr 431923

Logs: https://github.com/acid-bong/nixpkgs-review-gha/actions/runs/16823032455


x86_64-linux

✅ 1 package built:
  • github-linguist

aarch64-linux

✅ 1 package built:
  • github-linguist

x86_64-darwin (sandbox = true)

✅ 1 package built:
  • github-linguist

aarch64-darwin (sandbox = true)

✅ 1 package built:
  • github-linguist

Copy link
Contributor

@acid-bong acid-bong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved automatically following the successful run of nixpkgs-review.

@nixpkgs-ci nixpkgs-ci bot added the 12.approvals: 1 This PR was reviewed and approved by one person. label Aug 8, 2025
Copy link
Member

@Cryolitia Cryolitia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Cryolitia Cryolitia added 12.approvals: 2 This PR was reviewed and approved by two persons. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages. and removed 12.approvals: 1 This PR was reviewed and approved by one person. labels Aug 10, 2025
@Sigmanificient Sigmanificient merged commit af22c96 into NixOS:master Aug 13, 2025
33 of 35 checks passed
@tebriel tebriel mentioned this pull request Sep 2, 2025
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 12.approvals: 2 This PR was reviewed and approved by two persons. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages. 12.first-time contribution This PR is the author's first one; please be gentle!

Projects

None yet

Development

Successfully merging this pull request may close these issues.

github-linguist: gem extension build warnings

4 participants