Skip to content

lolcat: fix local gem ignored warning#416427

Merged
pbsds merged 1 commit intoNixOS:masterfrom
kirillrdy:lolcat2
Jun 14, 2025
Merged

lolcat: fix local gem ignored warning#416427
pbsds merged 1 commit intoNixOS:masterfrom
kirillrdy:lolcat2

Conversation

@kirillrdy
Copy link
Member

second attempt to fix #400243

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • Nixpkgs 25.11 Release Notes (or backporting 24.11 and 25.05 Nixpkgs Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
  • NixOS 25.11 Release Notes (or backporting 24.11 and 25.05 NixOS Release notes)
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other contributing documentation in corresponding paths.

Add a 👍 reaction to pull requests you find important.

@kirillrdy kirillrdy requested a review from ryand56 June 13, 2025 11:41
@kirillrdy kirillrdy marked this pull request as ready for review June 13, 2025 11:41
@kirillrdy
Copy link
Member Author

nix run github:NixOS/nixpkgs/11da150d8ee7f8bcd97e25bd448612c36245453f#lolcat -- <<< "help me"
help me

@github-actions github-actions bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Jun 13, 2025
@wolfgangwalther
Copy link
Contributor

Re-running CI due to a odd failure fixed in #416448

@ryand56 ryand56 added the 12.approvals: 1 This PR was reviewed and approved by one person. label Jun 13, 2025
@pbsds pbsds merged commit 11d9b36 into NixOS:master Jun 14, 2025
25 of 31 checks passed
@kirillrdy kirillrdy deleted the lolcat2 branch June 14, 2025 01:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 12.approvals: 1 This PR was reviewed and approved by one person.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

lolcat: Source locally installed gems is ignoring because it is missing extensions

4 participants