Skip to content

ocamlPackages.jsont: flags to turn off optional dependencies#430874

Merged
vbgl merged 1 commit intoNixOS:masterfrom
toastal:ocaml-jsont-optionals
Aug 5, 2025
Merged

ocamlPackages.jsont: flags to turn off optional dependencies#430874
vbgl merged 1 commit intoNixOS:masterfrom
toastal:ocaml-jsont-optionals

Conversation

@toastal
Copy link
Contributor

@toastal toastal commented Aug 4, 2025

learned from #430848 … tho somewhat awaiting whether one should prefer with* to *Support for flags in OCaml land.

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

1

Footnotes

  1. Please consider giving up MS GitHub or offering a non-proprietary, non-US-corporate-controlled mirror for this free software project. I wish to delete this Microsoft account in the future, but I need more projects like this to support alternative methods to send patches & contribute.

@toastal toastal requested review from marijanp, ulrikstrid and vbgl August 4, 2025 09:59
@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. 6.topic: ocaml OCaml is a general-purpose, high-level, multi-paradigm programming language. labels Aug 4, 2025
@toastal toastal force-pushed the ocaml-jsont-optionals branch from b563d89 to b74bc4b Compare August 4, 2025 11:34
@nixpkgs-ci nixpkgs-ci bot added the 12.approvals: 1 This PR was reviewed and approved by one person. label Aug 5, 2025
@vbgl vbgl merged commit 22ae0b2 into NixOS:master Aug 5, 2025
26 of 28 checks passed
@toastal toastal deleted the ocaml-jsont-optionals branch August 5, 2025 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: ocaml OCaml is a general-purpose, high-level, multi-paradigm programming language. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. 12.approvals: 1 This PR was reviewed and approved by one person.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants