ocamlPackages.logs: 0.8.0 → 0.9.0; refactor to buildTokpkg

[toastal]

#424216 like this but without changing the OCaml version checks. In fact, closes #424216. Bonus: we can mean what we say & unite with → RIGHTWARDS ARROW, not -> DASH + GREATER THAN (for @vbgl)!

Things done

• Built on platform:
  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
• Tested, as applicable:
  • NixOS tests in nixos/tests.
  • Package tests at passthru.tests.
  • Tests in lib/tests or pkgs/test for functions and "core" functionality.
• Ran nixpkgs-review on this PR. See nixpkgs-review usage.
• Tested basic functionality of all binary files, usually in ./result/bin/.
• Nixpkgs Release Notes
  • Package update: when the change is major or breaking.
• NixOS Release Notes
  • Module addition: when adding a new NixOS module.
  • Module update: when the change is significant.
• Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

---

Add a 👍 reaction to pull requests you find important.

¹

Footnotes

1. Please consider giving up MS GitHub or offering a non-proprietary, non-US-corporate-controlled mirror for this free software project. I wish to delete this Microsoft account in the future, but I need more projects like this to support alternative methods to send patches & contribute. ↩

[toastal]

Gonna rewrite this to use buildTopkgs

[sternenseemann]

Requires OCaml >= 4.14 now.

[toastal]

I pushed my rewrite WIP, but I will walk back & get both of these versions in

[toastal]

@sternenseemann

Addressed versioning.

Now we can fallback to 0.8.0 still + the diff here is still less lines!

[toastal]

This would also be a good time to ask… cmdlinerSupport or withCmdliner?

[toastal]

Okay, I think I am satisfied with the commit history now so it’s easiest to review

One last thing, I think it will be easier to make sense using newlines in the shell args for grouping.

[marijanp]

LGTM

[toastal]

This should be more in line with how Eio is set up https://github.com/NixOS/nixpkgs/blob/master/pkgs/development/ocaml-modules/eio/default.nix

[toastal]

@vbgl I could once again need help understand what inputs are buildInputs & what is propagatedBuildInputs

[toastal]

And adjacently: should we considering having like buildFlags on buildTopkg to avoid this sort of buildPhase override?

[toastal]

@vbgl @ulrikstrid could you help resolve this argumentation with the direction y’all want OCaml packages to go?

[toastal]

Since a month had past since #424216 & I wanted version 0.9.0 with no merge or acknowledgement from the maintainer, I had assumed this package was abandoned hence trying to update the code to match more contemporary style (& how I would have done it had I been the sole maintainer).

It's reasonably common, maybe not as common in code recently written, but I don't necessarily see a compelling reason to migrate existing code away from it.

In seeing a clash of that style & not wanting to fight, I do not wish to to co-maintain with @sternenseemann so I have removed myself from meta.maintainers & all attempts to make the style more in line with other more recent Nixpkgs packages. I did however:

• move to buildTopkg which remove a lot of the no-longer-needed cruft related to manual topkg usage
• have a switch to pick fall back to version 0.8.0 (following the pattern in ocamlPackages.eio & others)
• continuing to use fetchurl but with the exact sha512 (over sha256+SRI) from OPAM match the exact tarball (meaning not the tarball contents as in fetchzip)