tests: recourse into

[jopejoe1]

makes it so nixpkgs-review is running tests

Things done

• Built on platform:
  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
• Tested, as applicable:
  • NixOS tests in nixos/tests.
  • Package tests at passthru.tests.
  • Tests in lib/tests or pkgs/test for functions and "core" functionality.
• Ran nixpkgs-review on this PR. See nixpkgs-review usage.
• Tested basic functionality of all binary files, usually in ./result/bin/.
• Nixpkgs Release Notes
  • Package update: when the change is major or breaking.
• NixOS Release Notes
  • Module addition: when adding a new NixOS module.
  • Module update: when the change is significant.
• Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

---

Add a 👍 reaction to pull requests you find important.

[wolfgangwalther]

I like that. IIRC, the current state is that not all of these tests pass, correct? At least that was the case when I tried ~ two weeks ago, maybe that has changed by now.

[jopejoe1]

That's indeed the case, there are few that are failing to build.

[wolfgangwalther]

makes it so nixpkgs-review is running tests

How exactly does this surface? Aka, I still see 0 rebuilds - thus, I assume that Eval previously eval'ed the tests as well. What exactly is the difference now?

[jopejoe1]

Our ci evals nixpkgs over release-attrpaths-superset.nix where nixpkgs-review is not doing that and thuss the changes in release.nix are not affecting it.

[wolfgangwalther]

By default nixpkgs-review uses CI's eval results. Are you talking about nixpkgs-review --eval local explicitly?

[jopejoe1]

Yes im talking nixpkgs-review's own eval which i use for testing bevore opening a pr.