vips: 8.16.1 -> 8.17.1#429195
Conversation
|
|
dotlambda
left a comment
There was a problem hiding this comment.
❌ 2 packages failed to build:
* haskellPackages.gi-vips * haskellPackages.gi-vips.doc
That's a regression
|
Indeed, gi-vips needs to be fixed to depends on gi-gio. Patch opened upstream: haskell-gi/haskell-gi#475 |
58fe787 to
33ac032
Compare
maralorn
left a comment
There was a problem hiding this comment.
Thank you for your contribution! We generally try to avoid vendoring patches for haskell packages. Would it be possible to do this via fetchpatch like in the many other examples in configuration-common?
33ac032 to
9591dbc
Compare
9591dbc to
66c345c
Compare
|
The upstream fix for the failing vips-gi build has been merged and published as gi-vips 8.0.6: haskell-gi/haskell-gi#475, https://hackage.haskell.org/package/gi-vips-8.0.6 Now we just need to wait for hackage package updates to land in the |
|
It may be worth updating the haskell bindings manually for master and reverting that change on haskell-updates again, as long as the version is compatible with gi-* packages already on master. It may take weeks for haskell-updates to propagate to master still. |
|
I don't think the changes in vips are super important. We could merge this PR into haskell-updates or staging. |
|
Merging into haskell-updates sounds simplest. |
|
@ofborg build haskellPackages.gi-vips |
|
Successfully created backport PR for |
Diff: libvips/libvips@refs/tags/v8.16.1...refs/tags/v8.17.1
Changelog: https://github.com/libvips/libvips/blob/refs/tags/v8.17.1/ChangeLog
Things done
passthru.tests.nixpkgs-reviewon this PR. See nixpkgs-review usage../result/bin/.Add a 👍 reaction to pull requests you find important.