Skip to content

zipline: 4.2.1 -> 4.2.3, prune node_modules#432028

Merged
Defelo merged 2 commits intoNixOS:masterfrom
Defelo:push-kpzpznwunwkl
Aug 15, 2025
Merged

zipline: 4.2.1 -> 4.2.3, prune node_modules#432028
Defelo merged 2 commits intoNixOS:masterfrom
Defelo:push-kpzpznwunwkl

Conversation

@Defelo
Copy link
Member

@Defelo Defelo commented Aug 8, 2025 •
edited
Loading

Changelog: https://github.com/diced/zipline/releases/tag/v4.2.2
Diff: diced/zipline@v4.2.1...v4.2.2

Changelog: https://github.com/diced/zipline/releases/tag/v4.2.3
Diff: diced/zipline@v4.2.2...v4.2.3

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

@Defelo Defelo added 1.severity: security Issues which raise a security issue, or PRs that fix one 8.has: package (update) This PR updates a package to a newer version backport release-25.05 labels Aug 8, 2025
@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Aug 8, 2025
@Defelo

This comment was marked as outdated.

Sign in to view
@Defelo

This comment was marked as outdated.

Sign in to view
@Defelo
zipline: prune node_modules
bedeb5b 
This reduces the closure size from 3.7 GiB to 2.4 GiB.
@Defelo Defelo force-pushed the push-kpzpznwunwkl branch from 975262e to fa7dbe2 Compare August 13, 2025 11:53
@Defelo Defelo changed the title zipline: 4.2.1 -> 4.2.2 zipline: 4.2.1 -> 4.2.3, prune node_modules Aug 13, 2025
@Defelo

This comment has been minimized.

Sign in to view
@Defelo Defelo marked this pull request as ready for review August 13, 2025 12:17
@nixpkgs-ci nixpkgs-ci bot added the 9.needs: reviewer This PR currently has no reviewers requested and needs attention. label Aug 13, 2025
@Defelo Defelo force-pushed the push-kpzpznwunwkl branch from fa7dbe2 to ed4ce19 Compare August 13, 2025 12:38
@nixpkgs-ci nixpkgs-ci bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` and removed 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Aug 13, 2025
@Defelo
Copy link
Member Author

Defelo commented Aug 13, 2025

nixpkgs-review result

Generated using nixpkgs-review-gha

Command: nixpkgs-review pr 432028 -a zipline.tests
Commit: ed4ce1954409aff79aa10a03f61813ae5a6f6957 (subsequent changes)
Merge: 8a6990712ef01d4c3a6def0fb6edda0f717068db

Logs: https://github.com/Defelo/nixpkgs-review-gha/actions/runs/16938920913

x86_64-linux

⏩ 2 packages blacklisted:
  • nixos-install-tools
  • tests.nixos-functions.nixos-test
✅ 2 packages built:
  • zipline
  • zipline.tests.zipline

aarch64-linux

⏩ 2 packages blacklisted:
  • nixos-install-tools
  • tests.nixos-functions.nixos-test
✅ 1 package built:
  • zipline

@nixpkgs-ci nixpkgs-ci bot added 12.approvals: 1 This PR was reviewed and approved by one person. and removed 9.needs: reviewer This PR currently has no reviewers requested and needs attention. labels Aug 15, 2025
@Defelo Defelo merged commit 409bce8 into NixOS:master Aug 15, 2025
30 of 32 checks passed
@Defelo Defelo deleted the push-kpzpznwunwkl branch August 15, 2025 10:54
@nixpkgs-ci
Copy link
Contributor

nixpkgs-ci bot commented Aug 15, 2025

Successfully created backport PR for release-25.05:

@nixpkgs-ci nixpkgs-ci bot mentioned this pull request Aug 15, 2025
Merged
1 task
@github-actions github-actions bot added the 8.has: port to stable This PR already has a backport to the stable release. label Aug 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@SuperSandro2000 SuperSandro2000 SuperSandro2000 approved these changes

Assignees

No one assigned

Labels

1.severity: security Issues which raise a security issue, or PRs that fix one 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 8.has: package (update) This PR updates a package to a newer version 8.has: port to stable This PR already has a backport to the stable release. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 12.approvals: 1 This PR was reviewed and approved by one person.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Defelo @SuperSandro2000