Skip to content

python3Packages.pygments: 2.19.1 -> 2.19.2 #428030

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
GaetanLepage merged 2 commits into from
Aug 3, 2025
Merged

python3Packages.pygments: 2.19.1 -> 2.19.2 #428030

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8362fde
python3Packages.pygments: 2.19.1 -> 2.19.2
ryand56 Jul 25, 2025
2f9f0ac
python3Packages.pygments: add ryand56 as maintainer
ryand56 Jul 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 6 additions & 5 deletions pkgs/development/python-modules/pygments/default.nix
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,14 +15,12 @@
let
pygments = buildPythonPackage rec {
pname = "pygments";
version = "2.19.1";
version = "2.19.2";
pyproject = true;

disabled = pythonOlder "3.8"; # 2.18.0 requirement

src = fetchPypi {
inherit pname version;
hash = "sha256-YcFtKoV23AZJ2fOeCJtfArzSf7oQ2PtNzCgXP3pFFR8=";
hash = "sha256-Y2yyR3zsf4lSU2lwvFM7xDdDVC9wOSrgJjdGAK3VuIc=";
};
Comment on lines 21 to 24
Copy link
Contributor

@GaetanLepage GaetanLepage Jul 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was able to successfully use

fetchFromGitHub {
  owner = "pygments";
  repo = "pygments";
  tag = version;
  hash = "";
};

Copy link
Contributor

@gaelj gaelj Jul 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should use a hash whenever we can, for reproducibility and security.

Copy link
Member Author

@ryand56 ryand56 Jul 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would see #428030 (comment) above in regards to this. I think keeping fetchPypi would be best for now

Copy link
Contributor

@GaetanLepage GaetanLepage Jul 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should use a hash whenever we can, for reproducibility and security.

I left the hash empty in my snippet because I didn't want to copy-paste it. Of course, this would not be left as an empty string ;)

Copy link
Contributor

@gaelj gaelj Jul 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry for my misunderstanding


nativeBuildInputs = [ hatchling ];
Expand Down Expand Up @@ -54,7 +52,10 @@ let
description = "Generic syntax highlighter";
mainProgram = "pygmentize";
license = lib.licenses.bsd2;
maintainers = with lib.maintainers; [ sigmanificient ];
maintainers = with lib.maintainers; [
sigmanificient
ryand56
];
};
};
in
Expand Down
Loading