python3Packages.pygments: 2.19.1 -> 2.19.2#428030
Merged
GaetanLepage merged 2 commits intoNixOS:stagingfrom Aug 3, 2025
Merged
python3Packages.pygments: 2.19.1 -> 2.19.2#428030GaetanLepage merged 2 commits intoNixOS:stagingfrom
GaetanLepage merged 2 commits intoNixOS:stagingfrom
Conversation
3 tasks
dtomvan
reviewed
Jul 25, 2025
13 tasks
Comment on lines
23
to
24
Contributor
There was a problem hiding this comment.
I was able to successfully use
fetchFromGitHub {
owner = "pygments";
repo = "pygments";
tag = version;
hash = "";
};
Contributor
There was a problem hiding this comment.
I think we should use a hash whenever we can, for reproducibility and security.
Member
Author
There was a problem hiding this comment.
I would see #428030 (comment) above in regards to this. I think keeping fetchPypi would be best for now
Contributor
There was a problem hiding this comment.
I think we should use a hash whenever we can, for reproducibility and security.
I left the hash empty in my snippet because I didn't want to copy-paste it. Of course, this would not be left as an empty string ;)
Contributor
There was a problem hiding this comment.
sorry for my misunderstanding
13 tasks
GaetanLepage
approved these changes
Jul 28, 2025
gepbird
approved these changes
Aug 1, 2025
kirillrdy
approved these changes
Aug 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://github.com/pygments/pygments/releases/tag/2.19.2
Diff: pygments/pygments@2.19.1...2.19.2
Things done
passthru.tests.nixpkgs-reviewon this PR. See nixpkgs-review usage../result/bin/.Add a 👍 reaction to pull requests you find important.