Skip to content

python3Packages.pygments: 2.19.1 -> 2.19.2#428030

Merged
GaetanLepage merged 2 commits intoNixOS:stagingfrom
ryand56:update/pygments
Aug 3, 2025
Merged

python3Packages.pygments: 2.19.1 -> 2.19.2#428030
GaetanLepage merged 2 commits intoNixOS:stagingfrom
ryand56:update/pygments

Conversation

@ryand56
Copy link
Member

@ryand56 ryand56 commented Jul 24, 2025

https://github.com/pygments/pygments/releases/tag/2.19.2
Diff: pygments/pygments@2.19.1...2.19.2

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 5001+ This PR causes many rebuilds on Darwin and must target the staging branches. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches. 6.topic: python Python is a high-level, general-purpose programming language. labels Jul 24, 2025
@ryand56 ryand56 marked this pull request as ready for review July 24, 2025 12:24
@nix-owners nix-owners bot requested a review from Sigmanificient July 24, 2025 12:25
Comment on lines 23 to 24
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was able to successfully use

fetchFromGitHub {
  owner = "pygments";
  repo = "pygments";
  tag = version;
  hash = "";
};

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should use a hash whenever we can, for reproducibility and security.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would see #428030 (comment) above in regards to this. I think keeping fetchPypi would be best for now

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should use a hash whenever we can, for reproducibility and security.

I left the hash empty in my snippet because I didn't want to copy-paste it. Of course, this would not be left as an empty string ;)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry for my misunderstanding

@GaetanLepage GaetanLepage requested a review from mweinelt July 28, 2025 14:28
@nixpkgs-ci nixpkgs-ci bot added the 12.approvals: 1 This PR was reviewed and approved by one person. label Jul 28, 2025
@nixpkgs-ci nixpkgs-ci bot added 12.approvals: 2 This PR was reviewed and approved by two persons. and removed 12.approvals: 1 This PR was reviewed and approved by one person. labels Aug 1, 2025
@GaetanLepage GaetanLepage requested a review from kirillrdy August 3, 2025 23:07
@GaetanLepage GaetanLepage merged commit ed6ac21 into NixOS:staging Aug 3, 2025
28 of 29 checks passed
@ryand56 ryand56 deleted the update/pygments branch August 3, 2025 23:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: python Python is a high-level, general-purpose programming language. 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 5001+ This PR causes many rebuilds on Darwin and must target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches. 12.approvals: 2 This PR was reviewed and approved by two persons.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants