[25.05] various: avoid throwing for invalid platforms combinations in CI#427372
Merged
wolfgangwalther merged 5 commits intoNixOS:release-25.05from Jul 22, 2025
Merged
Conversation
This assert is already handled by `meta.platforms`, which can be better caught by CI than an `assert`. Also set `meta.platforms` to the earlier defined `hplipPlatforms` for a single source of truth. (cherry picked from commit 715d372)
These asserts should only trigger when a user tries to use that combination. In CI, they should just not create an attrpath to evaluate. (cherry picked from commit 093e739)
Same reasoning as commit before. (cherry picked from commit e26ecf5)
Same reasoning as in the commit before. (cherry picked from commit f115f69)
An assert can't be caught by CI for generation of attrpaths during Eval. An error reported via meta.badPlatforms can be. The alternative of returning null in the CI case, similar to the commits before, is not helpful, because it only causes failed builds or eval downstream - when this dependency is passed on and used as `null`. (cherry picked from commit 6de5573)
nix-owners
bot
requested review from
Br1ght0ne,
DianaOlympos,
adamcstephens,
ankhers,
gleber,
happysalada and
yurrriq
nixpkgs-ci
bot
added
10.rebuild-darwin: 0
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
wolfgangwalther
dismissed
github-actions[bot]’s stale review
resolved conflict, because passthru.updateScript wasn't present on 25.05, yet.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Manual backport of #426645 and #427183.
Only trivial conflicts to resolve.