hplipWithPlugin: remove assert#427183
Merged
philiptaron merged 1 commit intoNixOS:masterfrom Jul 21, 2025
Merged
Conversation
This assert is already handled by `meta.platforms`, which can be better caught by CI than an `assert`. Also set `meta.platforms` to the earlier defined `hplipPlatforms` for a single source of truth.
nixpkgs-ci
bot
added
10.rebuild-darwin: 0
MattSturgeon
approved these changes
Jul 21, 2025
nixpkgs-ci
bot
added
the
12.approvals: 1
philiptaron
approved these changes
Jul 21, 2025
This comment was marked as resolved.
This comment was marked as resolved.
wolfgangwalther
added
the
8.has: port to stable
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This assert is already handled by
meta.platforms, which can be better caught by CI than anassert. Also setmeta.platformsto the earlier definedhplipPlatformsfor a single source of truth.Related: #426629
Things done
Add a 👍 reaction to pull requests you find important.