Skip to content

Conversation

@FlameFlag
Copy link
Member

@FlameFlag FlameFlag commented Jul 11, 2025

Things done

Backports of:
#416071
#417922
#418302
#418601
#419756
#420275
#420897
#421374
#421886
#422680

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • Nixpkgs 25.11 Release Notes (or backporting 25.05 Nixpkgs Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
  • NixOS 25.11 Release Notes (or backporting 25.05 NixOS Release notes)
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other contributing documentation in corresponding paths.

Add a 👍 reaction to pull requests you find important.

botnk and others added 12 commits July 11, 2025 14:48
(cherry picked from commit e7ee8bf)
@nixpkgs-ci nixpkgs-ci bot added the 4.workflow: backport This targets a stable branch label Jul 11, 2025
@nix-owners nix-owners bot requested review from GaetanLepage and niklaskorz July 11, 2025 11:59
@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. labels Jul 11, 2025
@niklaskorz
Copy link
Contributor

If you read #416071, you'll see that this is not possible, as Rust 1.87+ is required to build Zed 0.190 and newer. For a moment I was hopeful that they reverted use of the std library function that increased the minimum supported Rust version, but it appears you did not even try to to build your branch before opening the PR.

zed-editor> error[E0658]: use of unstable library feature `anonymous_pipe`
zed-editor>   --> crates/util/src/shell_env.rs:74:32
zed-editor>    |
zed-editor> 74 |     let (mut reader, writer) = std::io::pipe()?;
zed-editor>    |                                ^^^^^^^^^^^^^
zed-editor>    |
zed-editor>    = note: see issue #127154 <https://github.com/rust-lang/rust/issues/127154> for more information

@niklaskorz niklaskorz closed this Jul 11, 2025
@niklaskorz
Copy link
Contributor

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 424297
Commit: e0188a66fd778ecac69d2733e0cc7988e8908792


aarch64-darwin

❌ 2 packages failed to build:
  • zed-editor
  • zed-editor.remote_server

Error logs: `aarch64-darwin`
zed-editor
   Compiling documented v0.9.1
   Compiling objc2-audio-toolbox v0.3.1
   Compiling sqlformat v0.2.6
   Compiling ui_macros v0.1.0 (/nix/var/nix/builds/nix-build-zed-editor-0.193.3.drv-0/source/crates/ui_macros)
   Compiling util v0.1.0 (/nix/var/nix/builds/nix-build-zed-editor-0.193.3.drv-0/source/crates/util)
error[E0658]: use of unstable library feature `anonymous_pipe`
  --> crates/util/src/shell_env.rs:74:32
   |
74 |     let (mut reader, writer) = std::io::pipe()?;
   |                                ^^^^^^^^^^^^^
   |
   = note: see issue #127154  for more information

Compiling livekit_api v0.1.0 (/nix/var/nix/builds/nix-build-zed-editor-0.193.3.drv-0/source/crates/livekit_api)
Compiling coreaudio-rs v0.11.3
Compiling simple_asn1 v0.6.3
Compiling webrtc-sys v0.3.7 (https://github.com/zed-industries/livekit-rust-sdks?rev=80bb8f4c9112789f7c24cc98d8423010977806a6#80bb8f4c)
For more information about this error, try rustc --explain E0658.
error: could not compile util (lib) due to 1 previous error
warning: build failed, waiting for other jobs to finish...

@FlameFlag
Copy link
Member Author

FlameFlag commented Jul 11, 2025

Oof, sorry, that's on me. I was wondering why stable is so behind, and thought that someone forgot to backport the commits, but that wasn't the case. I'll try to do better in the future

@FlameFlag FlameFlag deleted the push-kpqumsxxxpln branch July 11, 2025 12:26
@niklaskorz
Copy link
Contributor

Oof, sorry, that's on me. I was wondering why stable is so behind, and thought that someone forgot to backport the commits, but that wasn't the case. I'll try to do better in the future

We were trying to get upstream to give us a bit more time with MSRV bumps, but as can be seen in #423935 they are still jumping the gun on day one. :')

Upstream issue for reference: zed-industries/zed#17402

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

4.workflow: backport This targets a stable branch 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants