-
-
Notifications
You must be signed in to change notification settings - Fork 17.2k
zed-editor: skip test test_open_workspace_with_directory #422680
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
bryango
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would suggest adding cargoTestFlags = [ "--no-fail-fast" ]; as it costs a lot (1h+) to rebuild the package. But this is just a non-blocking suggestion, I am also okay with the change as-is.
This will still cause the build to fail, just much later and wasting time. Maybe you mean https://doc.rust-lang.org/cargo/commands/cargo-test.html#miscellaneous-options
|
b77d285 to
7dc50f4
Compare
|
|
|
Thanks! |
Hydra failure: https://hydra.nixos.org/build/301728237
Resolves: #422673
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.