Skip to content

Conversation

@Prince213
Copy link
Member

@Prince213 Prince213 commented Jul 5, 2025

Hydra failure: https://hydra.nixos.org/build/301728237
Resolves: #422673

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • Nixpkgs 25.11 Release Notes (or backporting 25.05 Nixpkgs Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
  • NixOS 25.11 Release Notes (or backporting 25.05 NixOS Release notes)
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other contributing documentation in corresponding paths.

Add a 👍 reaction to pull requests you find important.

@Prince213 Prince213 added the 0.kind: build failure A package fails to build label Jul 5, 2025
Copy link
Member

@bryango bryango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would suggest adding cargoTestFlags = [ "--no-fail-fast" ]; as it costs a lot (1h+) to rebuild the package. But this is just a non-blocking suggestion, I am also okay with the change as-is.

@Prince213
Copy link
Member Author

I would suggest adding cargoTestFlags = [ "--no-fail-fast" ]; as it costs a lot (1h+) to rebuild the package.

This will still cause the build to fail, just much later and wasting time. Maybe you mean --keep-going, but that is not available for cargo test.

https://doc.rust-lang.org/cargo/commands/cargo-test.html#miscellaneous-options

While cargo test involves compilation, it does not provide a --keep-going flag.

@Prince213 Prince213 added the 12.approvals: 1 This PR was reviewed and approved by one person. label Jul 5, 2025
@nix-owners nix-owners bot requested a review from GaetanLepage July 5, 2025 10:24
@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. labels Jul 5, 2025
@Prince213 Prince213 force-pushed the push-quukyvwpskzk branch from b77d285 to 7dc50f4 Compare July 5, 2025 10:39
@niklaskorz
Copy link
Contributor

niklaskorz commented Jul 5, 2025

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 422680
Commit: 7dc50f45d3cace41e19adf4887ea85691fbb2ec0

(confirming no rebuilds on Linux)

@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. and removed 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Jul 5, 2025
@niklaskorz
Copy link
Contributor

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 422680
Commit: 7dc50f45d3cace41e19adf4887ea85691fbb2ec0


aarch64-darwin

✅ 2 packages built:
  • zed-editor
  • zed-editor.remote_server

@niklaskorz niklaskorz merged commit c946072 into NixOS:master Jul 5, 2025
24 of 28 checks passed
@Prince213
Copy link
Member Author

Thanks!

@Prince213 Prince213 deleted the push-quukyvwpskzk branch September 21, 2025 03:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

0.kind: build failure A package fails to build 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. 12.approvals: 1 This PR was reviewed and approved by one person.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Build failure: zed-editor

3 participants