Skip to content

nixos/npm: add npm to the system closure by default#42420

Merged
xeji merged 1 commit intoNixOS:masterfrom
Ma27:improve-npm-module
Jun 24, 2018
Merged

nixos/npm: add npm to the system closure by default#42420
xeji merged 1 commit intoNixOS:masterfrom
Ma27:improve-npm-module

Conversation

@Ma27
Copy link
Member

@Ma27 Ma27 commented Jun 23, 2018

Motivation for this change

Similar to #42410, when I enable a program I want to have it available globally.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@GrahamcOfBorg GrahamcOfBorg added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Jun 23, 2018
@xeji xeji merged commit db493ad into NixOS:master Jun 24, 2018
@Ma27 Ma27 deleted the improve-npm-module branch June 24, 2018 23:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants