nixos/screen: add pkgs.screen to the system closure

[Ma27]

Motivation for this change

When enabling any software in programs.* the package should be available globally. Just adding config files seems fairly counterintuitive.

Things done

• Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
• Built on platform(s)
  • NixOS
  • macOS
  • other Linux distributions
• Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
• Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
• Tested execution of all binary files (usually in ./result/bin/)
• Determined the impact on package closure size (by running nix path-info -S before and after)
• Fits CONTRIBUTING.md.

---

[andir]

Good catch! 👍

This should probably have done a long time ago.

One small (optional?) nitpick:

Since this "issue" was introduced in 2013 and people that use the programs.screen option must have added screen to their system package set manually. Having a note in the changelog about this would be nice so people can cleanup on the next update/release when they (should) go through the changes listed there.

[Ma27]

@andir you're absolutely right! I added a new paragraph in Other notable changes and built the docs locally for testing :)