Skip to content

python3Packages.mmengine: explicitly add distutils dep instead of patching#424002

Merged
GaetanLepage merged 1 commit intoNixOS:masterfrom
GaetanLepage:mmengine
Jul 10, 2025
Merged

python3Packages.mmengine: explicitly add distutils dep instead of patching#424002
GaetanLepage merged 1 commit intoNixOS:masterfrom
GaetanLepage:mmengine

Conversation

@GaetanLepage
Copy link
Copy Markdown
Contributor

@GaetanLepage GaetanLepage commented Jul 10, 2025 •
edited
Loading

Things done

Addresses #423183 (comment)

cc @SuperSandro2000

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • Nixpkgs 25.11 Release Notes (or backporting 25.05 Nixpkgs Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
  • NixOS 25.11 Release Notes (or backporting 25.05 NixOS Release notes)
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other contributing documentation in corresponding paths.

Add a 👍 reaction to pull requests you find important.

@nix-owners nix-owners bot requested a review from benxiao July 10, 2025 09:37
@nixpkgs-ci nixpkgs-ci bot added 6.topic: python Python is a high-level, general-purpose programming language. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. and removed 6.topic: python Python is a high-level, general-purpose programming language. labels Jul 10, 2025
@GaetanLepage GaetanLepage mentioned this pull request Jul 10, 2025
Merged
13 tasks
@GaetanLepage
Copy link
Copy Markdown
Contributor Author

GaetanLepage commented Jul 10, 2025

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 424002
Commit: 56c34758244e6b759df9b604b35ce1c985ca3c8b

x86_64-linux

✅ 8 packages built:
  • python312Packages.mmcv
  • python312Packages.mmcv.dist
  • python312Packages.mmengine
  • python312Packages.mmengine.dist
  • python313Packages.mmcv
  • python313Packages.mmcv.dist
  • python313Packages.mmengine
  • python313Packages.mmengine.dist

@nixpkgs-ci nixpkgs-ci bot added the 12.approvals: 1 This PR was reviewed and approved by one person. label Jul 10, 2025
@GaetanLepage GaetanLepage merged commit 85a04d3 into NixOS:master Jul 10, 2025
30 of 34 checks passed
@GaetanLepage GaetanLepage deleted the mmengine branch July 10, 2025 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kirillrdy kirillrdy kirillrdy approved these changes

@benxiao benxiao Awaiting requested review from benxiao

@SuperSandro2000 SuperSandro2000 Awaiting requested review from SuperSandro2000

Assignees

No one assigned

Labels

10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 12.approvals: 1 This PR was reviewed and approved by one person.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@GaetanLepage @kirillrdy