Skip to content

python3Packages.mmengine: use setuptools._distutils instead of deprecated distutils#423183

Merged
GaetanLepage merged 1 commit intoNixOS:masterfrom
GaetanLepage:mmengine
Jul 7, 2025
Merged

python3Packages.mmengine: use setuptools._distutils instead of deprecated distutils#423183
GaetanLepage merged 1 commit intoNixOS:masterfrom
GaetanLepage:mmengine

Conversation

@GaetanLepage
Copy link
Copy Markdown
Contributor

@GaetanLepage GaetanLepage commented Jul 7, 2025

Things done

This fixes the following error identified when running nixpkgs-review on #419179.

>       from distutils import errors
E       ModuleNotFoundError: No module named 'distutils'

mmengine/utils/dl_utils/collect_env.py:54: ModuleNotFoundErro
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • Nixpkgs 25.11 Release Notes (or backporting 25.05 Nixpkgs Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
  • NixOS 25.11 Release Notes (or backporting 25.05 NixOS Release notes)
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other contributing documentation in corresponding paths.

Add a 👍 reaction to pull requests you find important.

@GaetanLepage GaetanLepage requested a review from kirillrdy July 7, 2025 11:52
@nixpkgs-ci nixpkgs-ci bot added the 6.topic: python Python is a high-level, general-purpose programming language. label Jul 7, 2025
@nix-owners nix-owners bot requested a review from benxiao July 7, 2025 11:58
@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. labels Jul 7, 2025
@GaetanLepage
Copy link
Copy Markdown
Contributor Author

nixpkgs-review result

Generated using nixpkgs-review-gha

Command: nixpkgs-review pr 423183

Logs: https://github.com/GaetanLepage/nixpkgs-review-gha/actions/runs/16116184239


x86_64-linux

✅ 8 packages built:
  • python312Packages.mmcv
  • python312Packages.mmcv.dist
  • python312Packages.mmengine
  • python312Packages.mmengine.dist
  • python313Packages.mmcv
  • python313Packages.mmcv.dist
  • python313Packages.mmengine
  • python313Packages.mmengine.dist

aarch64-linux

✅ 8 packages built:
  • python312Packages.mmcv
  • python312Packages.mmcv.dist
  • python312Packages.mmengine
  • python312Packages.mmengine.dist
  • python313Packages.mmcv
  • python313Packages.mmcv.dist
  • python313Packages.mmengine
  • python313Packages.mmengine.dist

@nixpkgs-ci nixpkgs-ci bot added the 12.approvals: 1 This PR was reviewed and approved by one person. label Jul 7, 2025
@GaetanLepage GaetanLepage merged commit 1e7446b into NixOS:master Jul 7, 2025
31 of 35 checks passed
@GaetanLepage GaetanLepage deleted the mmengine branch July 7, 2025 22:21
@SuperSandro2000
Copy link
Copy Markdown
Member

That distutils is also kinda deprecated, I think like the whole of distutils.

https://setuptools.pypa.io/en/latest/deprecated/distutils/index.html

Not sure if the distutils package is deprecated (probably, too) but it is probably easier to just plot that in because setuptools might eventually drop that vendored distutils, too.

@GaetanLepage
Copy link
Copy Markdown
Contributor Author

That distutils is also kinda deprecated, I think like the whole of distutils.

https://setuptools.pypa.io/en/latest/deprecated/distutils/index.html

Not sure if the distutils package is deprecated (probably, too) but it is probably easier to just plot that in because setuptools might eventually drop that vendored distutils, too.

Opened #424002.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: python Python is a high-level, general-purpose programming language. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 12.approvals: 1 This PR was reviewed and approved by one person.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants