Conversation
We can't say final farewell for it, due ffado-mixer, which give us nice build-loop, so postpone it until I (or someone other) write separate derivation for mixer-only (because is just python script, with dependencies in PyQT/PyDbus)
GrahamcOfBorg
added
8.has: clean-up
|
Only shotcut fails to build, but this is currently broken on hydra. cc @woffs |
|
Built yesterday on top of 56b867c alongside with other my WIP commits |
| scons PREFIX=$out PYPKGDIR=$PYDIR UDEVDIR=$out/lib/udev/rules.d install | ||
| '' + stdenv.lib.optionalString (optPyqt4 != null && optPythonDBus != null) '' | ||
| installPhase = '' | ||
| scons ${SCONS_OPTIONS} ${if mixerOnly then "${BINDIR} ${PYDIR}" else "install"} |
There was a problem hiding this comment.
You don't have to do this here, but eventually I want to get scons to have setup hook that defines these phases (like is done with cmake, ninja, etc...).
There was a problem hiding this comment.
IDK other legal way to bypass library build, when we build only mixer. scons $out/lib/python $out/bin force installing only needed stuff.
There was a problem hiding this comment.
@matthewbauer what can I do, to get this one PR merged? Is a deepest rebuild trigger in my WIP tree at the moment. (probably we can even drop mixer temporary, and make separate package for it, if anyone need it really)
|
Sorry for the lateness. Merged in 78cabc3. |
4 participants
Motivation for this change
Say "farewell" to long-lived ad-hoc hack, when we had two derivations for one package -- one for library-only version, second one with mixer built.
This PR contain finalized ffado rework, factored out of #38494
(because it hard to maintain so long live branch, which cause significant local rebuild)
ffado itself splitted into two derivations:
ffadoandffado-mixer(latter contain some qt/dbus based mixer). This was needed to avoid build dependency loop.See #14693 for problem history and details.
PS. Would be nice, if someone who have actual ffado backed hardware to test
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)