[WIP] Refactor libprefixed packages to multioutput by avnik · Pull Request #38494 · NixOS/nixpkgs

avnik · 2018-04-06T01:31:48Z

Motivation for this change

Say "farewell" to long-lived ad-hoc hack, when we had two derivations for one package -- one for library-only version, second one with server/utils built.

See #14693 for problem history and details.

Done (Minimum to be done)

ffado (complete, moved to own PR Lib-prefixed to multioutput: ffado #42294 )
ffado (aka ffadoFull --- ffado-mixer moved to own derivation, and included in PR above)
jack2 (waiting jack1 and own RP)
[ ] jack
[ ] pulseaudio (Work-in-progress, I still have some plans to split tools and daemon to own outputs)
heimdal (done, own PR Libprefixed to multioutput/heimdal #42295 )

Not sure about this two, my expertise can be not enough. If I fail to refactor them, I'll create separate issues

[ ] krb5

At least volunters for testing would be needed, I haven't any ffado compatible hardware, and can test stuff only for "just executed and shows version". Also I can't check darwin build myself.

I am sure, that is a mass-rebuild, so eventually this PR will be altered to be against staging. One of reasons, why I open PR early -- is prevend duplications of work, and use ofborg to look how much stuff affected.

Things done

Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
Built on platform(s)
- NixOS
- macOS
- other Linux distributions
Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
Tested execution of all binary files (usually in ./result/bin/)
Fits CONTRIBUTING.md.

We can't say final farewell for it, due ffado-mixer, which give us nice build-loop, so postpone it until I (or someone other) write separate derivation for mixer-only (because is just python script, with dependencies in PyQT/PyDbus)

matthewbauer · 2018-05-01T14:46:54Z

Hi! Thanks for doing this. I opened a similar PR in #39683 but you seem to have gotten further along. A few more that (maybe) can be removed:

libv4l
poppler_utils

matthewbauer · 2018-05-01T14:48:20Z

pkgs/os-specific/linux/ffado/default.nix

-  optAlsaLib = shouldUsePkg alsaLib;
+# Mixer/tools dependencies
+# FIXME: can we build mixer separately? Then we can farewell `libOnly` mode
+# (otherwise we have perfect loop via qt -> pulseaudio -> jack -> ffado -> qt)


We can probably override ffado in jack's callPackage-jack shouldn't need Qt.

ffado' mixer is actually separate app, which have completely own dependencies (dbus-python and PyQt), so I feel separate expression may be better solution. But would be nice to hear someone who use ffado.

matthewbauer · 2018-05-01T15:01:38Z

pkgs/misc/jackaudio/default.nix

-  optPythonDBus = if libOnly then null else shouldUsePkg dbus-python;
-  optLibffado = if libOnly then null else shouldUsePkg libffado;
-  optAlsaLib = if libOnly then null else shouldUsePkg alsaLib;
+  optPythonDBus = shouldUsePkg dbus-python;


You can probably get rid of shouldUsePkg. I think they are officially deprecated (just use dbus-python directly).

It don't used outside of mixer, so if we move mixer to own app, we can drop dbus-python in main ffado.

oxij · 2018-05-01T19:13:48Z

Let me note here (too) that I think that some parts of `libOnly` are useful #39683 (comment) and that the problem, as I see it, is not only that `libOnly` can be implemented with multiple outputs, but that it also is not a use-flag, i.e. derivations that use it are not monoidal #39683 (comment) and monoidal derivations are FTW.

avnik · 2018-05-01T21:42:07Z

@oxij libOnly here is definelly not use-flag.

Other question to all -- I had intention to split daemon part of pulseaudio from client binaries (to daemon and bin outputs respectively) -- does it a good idea, or too radical? Then we can drop some useflags from pulseaudio -- extra dependencies (like jack/ffado) needed only for daemon, but not for client utilities like pactl/pacmd/....

avnik · 2018-06-20T07:32:47Z

Some work, which already done kicked to own PRs, just updated this issue to keep progress tracking (still use it as WIP branch)

mmahut · 2019-08-03T14:43:44Z

What is the status of this pull request?

avnik · 2019-08-05T13:18:58Z

@mmahut ffado and heimdal done and merged. Pulseaudio still pending, I'll try to rebase my patches and push them to own PR, also I feel worth to migrate pulseaudio package to using meson, instead autoconf.

stale · 2020-06-01T17:08:45Z

Thank you for your contributions.
This has been automatically marked as stale because it has had no activity for 180 days.
If this is still important to you, we ask that you leave a comment below. Your comment can be as simple as "still important to me". This lets people see that at least one person still cares about this. Someone will have to do this at most twice a year if there is no other activity.
Here are suggestions that might help resolve this more quickly:

Search for maintainers and people that previously touched the
related code and @ mention them in a comment.
Ask on the NixOS Discourse. 3. Ask on the #nixos channel on
irc.freenode.net.

avnik · 2020-06-05T14:23:46Z

Actually only pulseaudio refactoring pending, so I can close it

avnik added 2 commits April 6, 2018 04:15

libffado: refactor lib-prefixed package

d09772e

We can't say final farewell for it, due ffado-mixer, which give us nice build-loop, so postpone it until I (or someone other) write separate derivation for mixer-only (because is just python script, with dependencies in PyQT/PyDbus)

jack2: Refactor lib-prefixed to multi-output

1596d7f

GrahamcOfBorg added 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. 10.rebuild-linux: 101-500 This PR causes between 101 and 500 packages to rebuild on Linux. labels Apr 6, 2018

avnik added 3 commits April 7, 2018 13:15

heimdal: refactor lib-prefixed packages to multi-output

19bf7c6

pulseaudio: refactor lib-prefixed stuff to multi-output

9102619

pulseaudio: fix broken .pc file, overall improvements

a605f9a

GrahamcOfBorg added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` labels Apr 13, 2018

matthewbauer added the 2.status: work-in-progress label Apr 21, 2018

dezgeg mentioned this pull request May 1, 2018

Remove uses of libOnly #39683

Closed

matthewbauer reviewed May 1, 2018

View reviewed changes

This was referenced Jun 20, 2018

Lib-prefixed to multioutput: ffado #42294

Closed

Libprefixed to multioutput/heimdal #42295

Merged

stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jun 1, 2020

avnik closed this Jun 5, 2020

avnik deleted the refactor/libprefixed-to-multioutput branch June 5, 2020 14:23

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[WIP] Refactor libprefixed packages to multioutput#38494

[WIP] Refactor libprefixed packages to multioutput#38494
avnik wants to merge 5 commits intoNixOS:masterfrom
avnik:refactor/libprefixed-to-multioutput

avnik commented Apr 6, 2018 •

edited

Loading

Uh oh!

matthewbauer commented May 1, 2018

Uh oh!

matthewbauer May 1, 2018

Uh oh!

avnik May 1, 2018

Uh oh!

matthewbauer May 1, 2018

Uh oh!

avnik May 1, 2018

Uh oh!

oxij commented May 1, 2018 via email

Uh oh!

avnik commented May 1, 2018

Uh oh!

avnik commented Jun 20, 2018

Uh oh!

mmahut commented Aug 3, 2019

Uh oh!

avnik commented Aug 5, 2019

Uh oh!

stale bot commented Jun 1, 2020

Uh oh!

avnik commented Jun 5, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Uh oh!

Conversation

avnik commented Apr 6, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Motivation for this change

Things done

Uh oh!

matthewbauer commented May 1, 2018

Uh oh!

matthewbauer May 1, 2018

Choose a reason for hiding this comment

Uh oh!

avnik May 1, 2018

Choose a reason for hiding this comment

Uh oh!

matthewbauer May 1, 2018

Choose a reason for hiding this comment

Uh oh!

avnik May 1, 2018

Choose a reason for hiding this comment

Uh oh!

oxij commented May 1, 2018 via email

Uh oh!

avnik commented May 1, 2018

Uh oh!

avnik commented Jun 20, 2018

Uh oh!

mmahut commented Aug 3, 2019

Uh oh!

avnik commented Aug 5, 2019

Uh oh!

stale bot commented Jun 1, 2020

Uh oh!

avnik commented Jun 5, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

avnik commented Apr 6, 2018 •

edited

Loading