python3Packages.torch-geometric: disable failing tests#422750
Merged
GaetanLepage merged 1 commit intoNixOS:masterfrom Jul 5, 2025
Merged
python3Packages.torch-geometric: disable failing tests#422750GaetanLepage merged 1 commit intoNixOS:masterfrom
GaetanLepage merged 1 commit intoNixOS:masterfrom
Conversation
Contributor
Author
|
Discovered in nixpkgs-review of #420628 |
Multiple tests are failing with module 'torch.fx._symbolic_trace' has no attribute 'List'.
d1c712f to
fa2929b
Compare
Contributor
Author
|
@GaetanLepage if you can prioritize this one since other fixes depend on it. |
Contributor
|
GaetanLepage
approved these changes
Jul 5, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Multiple tests are failing with
AttributeError: module 'torch.fx._symbolic_trace' has no attribute 'List'. Disabled.Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.