Skip to content

python3Packages.torch-geometric: disable failing tests#422750

Merged
GaetanLepage merged 1 commit intoNixOS:masterfrom
sarahec:torch-geometric-tests
Jul 5, 2025
Merged

python3Packages.torch-geometric: disable failing tests#422750
GaetanLepage merged 1 commit intoNixOS:masterfrom
sarahec:torch-geometric-tests

Conversation

@sarahec
Copy link
Contributor

@sarahec sarahec commented Jul 5, 2025

Multiple tests are failing with AttributeError: module 'torch.fx._symbolic_trace' has no attribute 'List'. Disabled.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • Nixpkgs 25.11 Release Notes (or backporting 25.05 Nixpkgs Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
  • NixOS 25.11 Release Notes (or backporting 25.05 NixOS Release notes)
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other contributing documentation in corresponding paths.

Add a 👍 reaction to pull requests you find important.

@sarahec
Copy link
Contributor Author

sarahec commented Jul 5, 2025

Discovered in nixpkgs-review of #420628

@nix-owners nix-owners bot requested a review from GaetanLepage July 5, 2025 17:47
@nixpkgs-ci nixpkgs-ci bot added 6.topic: python Python is a high-level, general-purpose programming language. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 9.needs: reviewer This PR currently has no reviewers requested and needs attention. and removed 9.needs: reviewer This PR currently has no reviewers requested and needs attention. labels Jul 5, 2025
Multiple tests are failing with module 'torch.fx._symbolic_trace' has no attribute 'List'.
@sarahec sarahec force-pushed the torch-geometric-tests branch from d1c712f to fa2929b Compare July 5, 2025 19:49
@sarahec
Copy link
Contributor Author

sarahec commented Jul 5, 2025

@GaetanLepage if you can prioritize this one since other fixes depend on it.

@GaetanLepage
Copy link
Contributor

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 422750
Commit: fa2929b89f08e40e2a2a773a5164b086d7f72fd1


x86_64-linux

✅ 8 packages built:
  • python312Packages.compressai
  • python312Packages.compressai.dist
  • python312Packages.torch-geometric
  • python312Packages.torch-geometric.dist
  • python313Packages.compressai
  • python313Packages.compressai.dist
  • python313Packages.torch-geometric
  • python313Packages.torch-geometric.dist

@GaetanLepage GaetanLepage merged commit 598820e into NixOS:master Jul 5, 2025
24 of 27 checks passed
@sarahec sarahec deleted the torch-geometric-tests branch July 5, 2025 23:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: python Python is a high-level, general-purpose programming language. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants