python3Packages.{plotly,chart-studio}: fixes#421308
Merged
GaetanLepage merged 4 commits intoNixOS:masterfrom Jul 12, 2025
Merged
python3Packages.{plotly,chart-studio}: fixes#421308GaetanLepage merged 4 commits intoNixOS:masterfrom
GaetanLepage merged 4 commits intoNixOS:masterfrom
Conversation
nixpkgs-ci
bot
added
10.rebuild-linux: 101-500
nixpkgs-ci
bot
added
12.approvals: 1
Pandapip1
approved these changes
Jul 1, 2025
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/prs-already-reviewed/2617/2444 |
Contributor
Author
|
Fixes multiple |
Contributor
Author
|
Taking to draft while merging prerequisite Prs. |
This was referenced Jul 6, 2025
Contributor
Author
|
13 tasks
13 tasks
Member
|
Both prerequisite PRs seem to be merged, and the wandb test failure seems to be unrelated. The segfaults are weird though. Should be good to undraft? |
Version bump, configure gitUpdater with the proper version prefix. changelog: https://github.com/plotly/plotly.py/releases/tag/v6.2.0 diff: plotly/plotly.py@v6.1.2...v6.2.0
…able-2025-01-30 Switch to new dedicated repository, move ref to current HEAD, fix homepage link.
Contributor
Author
Running Barring any big mess, we're likely good to go. I've just rebased over |
Contributor
Author
|
Contributor
Author
|
Contributor
Author
|
@Pandapip1 Let's gooooooo! |
Contributor
Author
|
@samuela this finally builds cleanly in nixpkgs-review so it's merge time! |
GaetanLepage
approved these changes
Jul 12, 2025
Contributor
GaetanLepage
left a comment
GaetanLepage
left a comment
There was a problem hiding this comment.
Ideally, failing tests should be reported upstream, but I understand it can be a lot of work if you start doing it for all packages.
Thanks for fixing these packages nonetheless :)
nixpkgs-ci
bot
added
12.approvals: 2
kirillrdy
approved these changes
Jul 12, 2025
Contributor
Author
I agree and generally file when:
The catch here is that when Darwin builds break on our infrastructure there's a good change it's the sandbox. Fortunately, testing with sandbox {on,relaxed,off} is usually enough to locate a cause. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Plotly: version bump; add maintainer
chart-studio: point to its new repo, version bump, disabled new tests that require local server. Add maintainer.
Part of fixing
nixpkgs-reviewfor #409698Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.