python3Packages.{plotly,chart-studio}: fixes#421308
python3Packages.{plotly,chart-studio}: fixes#421308GaetanLepage merged 4 commits intoNixOS:masterfrom
Conversation
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/prs-already-reviewed/2617/2444 |
|
Fixes multiple |
|
Taking to draft while merging prerequisite Prs. |
|
|
Both prerequisite PRs seem to be merged, and the wandb test failure seems to be unrelated. The segfaults are weird though. Should be good to undraft? |
Version bump, configure gitUpdater with the proper version prefix. changelog: https://github.com/plotly/plotly.py/releases/tag/v6.2.0 diff: plotly/plotly.py@v6.1.2...v6.2.0
…able-2025-01-30 Switch to new dedicated repository, move ref to current HEAD, fix homepage link.
Running Barring any big mess, we're likely good to go. I've just rebased over |
|
|
|
@Pandapip1 Let's gooooooo! |
|
@samuela this finally builds cleanly in nixpkgs-review so it's merge time! |
GaetanLepage
left a comment
There was a problem hiding this comment.
Ideally, failing tests should be reported upstream, but I understand it can be a lot of work if you start doing it for all packages.
Thanks for fixing these packages nonetheless :)
I agree and generally file when:
The catch here is that when Darwin builds break on our infrastructure there's a good change it's the sandbox. Fortunately, testing with sandbox {on,relaxed,off} is usually enough to locate a cause. |
Plotly: version bump; add maintainer
chart-studio: point to its new repo, version bump, disabled new tests that require local server. Add maintainer.
Part of fixing
nixpkgs-reviewfor #409698Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.