[Backport 25.05] [python3Packages.]ruff: 0.11.10 -> 0.11.13#421101
Merged
GaetanLepage merged 4 commits intoNixOS:release-25.05from Jun 30, 2025
Merged
[Backport 25.05] [python3Packages.]ruff: 0.11.10 -> 0.11.13#421101GaetanLepage merged 4 commits intoNixOS:release-25.05from
GaetanLepage merged 4 commits intoNixOS:release-25.05from
Conversation
Diff: astral-sh/ruff@refs/tags/0.11.10...refs/tags/0.11.11 Changelog: https://github.com/astral-sh/ruff/releases/tag/0.11.11 (cherry picked from commit fee2386)
Diff: astral-sh/ruff@refs/tags/0.11.11...refs/tags/0.11.12 Changelog: https://github.com/astral-sh/ruff/releases/tag/0.11.12 (cherry picked from commit b7692f3)
Diff: astral-sh/ruff@refs/tags/0.11.12...refs/tags/0.11.13 Changelog: https://github.com/astral-sh/ruff/releases/tag/0.11.13 (cherry picked from commit f916238)
nixpkgs-ci
bot
added
10.rebuild-linux: 11-100
bengsparks
changed the title
The maturin build system cannot see that we already build the ruff binary in nixpkgs. This leads to the ruff binary being rebuilt and placed inside of the resulting Python package. Every nixpkgs-review that passes through the `pkgs.ruff` package therefore builds `ruff` 3 times per architecture. Said binary was never even used due to the patching that already occurs in `find_ruff_bin`. Especially with how time-consuming release builds can be in Rust, there is no reason to keep this package in this state. master: `nix-build -A python3Packages.ruff` - `0.44s user 0.28s system 0% cpu 5:09.64 total` branch: `nix-build -A python3Packages.ruff` - `0.36s user 0.12s system 9% cpu 4.856 total` (cherry picked from commit cf311ad)
bengsparks
changed the title
nixpkgs-ci
bot
added
the
6.topic: python
Contributor
Author
|
Contributor
|
Contributor
Author
|
@GaetanLepage one of those failing packages has flaky tests (mcp?), and the rest depend on that package. I observe similar failures when building, but rerunning nixpkgs-review makes them pass |
Contributor
|
GaetanLepage
approved these changes
Jun 30, 2025
nixpkgs-ci
bot
added
12.approvals: 1
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Last backport of
ruffto 25.05, as the next version is 0.12.0.Includes #409860, #412083, #414356, as well #412112 for speeding up the rebuild of the Python package.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.