You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages
Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
Tested basic functionality of all binary files (usually in ./result/bin/)
../../../../nix/store/rqx1zz74m9917ww0hfb0b6fv0sap9573-python3.12-pydantic-2.11.1/lib/python3.12/site-packages/pydantic/_internal/_generate_schema.py:2331
/nix/store/rqx1zz74m9917ww0hfb0b6fv0sap9573-python3.12-pydantic-2.11.1/lib/python3.12/site-packages/pydantic/_internal/_generate_schema.py:2331: PydanticDeprecatedSince211: The `__get_pydantic_core_schema__` method of the `BaseModel` class is deprecated. If you are calling `super().__get_pydantic_core_schema__` when overriding the method on a Pydantic model, consider using `handler(source)` instead. However, note that overriding this method on models can lead to unexpected side effects. Deprecated in Pydantic V2.11 to be removed in V3.0.
schema = annotation_get_schema(source, get_inner_schema)
tests/test_types_validation.py::TestOAuthMetadata::test_model_dump_excludes_none
/nix/store/rqx1zz74m9917ww0hfb0b6fv0sap9573-python3.12-pydantic-2.11.1/lib/python3.12/site-packages/pydantic/main.py:453: UserWarning: Pydantic serializer warnings:
PydanticSerializationUnexpectedValue(Expected <class 'pydantic.networks.HttpUrl'> but got <class 'str'> with value 'https://example.com' - serialized value may not be as expected.)
PydanticSerializationUnexpectedValue(Expected <class 'pydantic.networks.HttpUrl'> but got <class 'str'> with value 'https://example.com/auth' - serialized value may not be as expected.)
PydanticSerializationUnexpectedValue(Expected <class 'pydantic.networks.HttpUrl'> but got <class 'str'> with value 'https://example.com/token' - serialized value may not be as expected.)
return self.pydantic_serializer.to_python(
-- Docs: https://docs.pytest.org/en/stable/how-to/capture-warnings.html
=========================== short test summary info ============================
ERROR tests/test_sse_real_transport.py::test_raw_sse_connection[asyncio] - RuntimeError: Server failed to start after 20 attempts
ERROR tests/test_sse_real_transport.py::test_sse_basic_connection[asyncio] - RuntimeError: Server failed to start after 20 attempts
ERROR tests/test_sse_real_transport.py::test_sse_tool_call[asyncio] - RuntimeError: Server failed to start after 20 attempts
ERROR tests/test_sse_real_transport.py::test_raw_sse_connection[trio] - RuntimeError: Server failed to start after 20 attempts
ERROR tests/test_sse_real_transport.py::test_sse_basic_connection[trio] - RuntimeError: Server failed to start after 20 attempts
ERROR tests/test_sse_real_transport.py::test_sse_tool_call[trio] - RuntimeError: Server failed to start after 20 attempts
================== 75 passed, 2 warnings, 6 errors in 29.53s ===================
python313Packages.fastapi-mcp
../../../../nix/store/4j9iv86xx8mfmzwyvc1mrxb9giijm5y7-python3.13-pydantic-2.11.1/lib/python3.13/site-packages/pydantic/_internal/_generate_schema.py:2331
/nix/store/4j9iv86xx8mfmzwyvc1mrxb9giijm5y7-python3.13-pydantic-2.11.1/lib/python3.13/site-packages/pydantic/_internal/_generate_schema.py:2331: PydanticDeprecatedSince211: The `__get_pydantic_core_schema__` method of the `BaseModel` class is deprecated. If you are calling `super().__get_pydantic_core_schema__` when overriding the method on a Pydantic model, consider using `handler(source)` instead. However, note that overriding this method on models can lead to unexpected side effects. Deprecated in Pydantic V2.11 to be removed in V3.0.
schema = annotation_get_schema(source, get_inner_schema)
tests/test_types_validation.py::TestOAuthMetadata::test_model_dump_excludes_none
/nix/store/4j9iv86xx8mfmzwyvc1mrxb9giijm5y7-python3.13-pydantic-2.11.1/lib/python3.13/site-packages/pydantic/main.py:453: UserWarning: Pydantic serializer warnings:
PydanticSerializationUnexpectedValue(Expected <class 'pydantic.networks.HttpUrl'> but got <class 'str'> with value 'https://example.com' - serialized value may not be as expected.)
PydanticSerializationUnexpectedValue(Expected <class 'pydantic.networks.HttpUrl'> but got <class 'str'> with value 'https://example.com/auth' - serialized value may not be as expected.)
PydanticSerializationUnexpectedValue(Expected <class 'pydantic.networks.HttpUrl'> but got <class 'str'> with value 'https://example.com/token' - serialized value may not be as expected.)
return self.pydantic_serializer.to_python(
-- Docs: https://docs.pytest.org/en/stable/how-to/capture-warnings.html
=========================== short test summary info ============================
ERROR tests/test_sse_real_transport.py::test_raw_sse_connection[asyncio] - RuntimeError: Server failed to start after 20 attempts
ERROR tests/test_sse_real_transport.py::test_sse_basic_connection[asyncio] - RuntimeError: Server failed to start after 20 attempts
ERROR tests/test_sse_real_transport.py::test_sse_tool_call[asyncio] - RuntimeError: Server failed to start after 20 attempts
ERROR tests/test_sse_real_transport.py::test_raw_sse_connection[trio] - RuntimeError: Server failed to start after 20 attempts
ERROR tests/test_sse_real_transport.py::test_sse_basic_connection[trio] - RuntimeError: Server failed to start after 20 attempts
ERROR tests/test_sse_real_transport.py::test_sse_tool_call[trio] - RuntimeError: Server failed to start after 20 attempts
================== 75 passed, 2 warnings, 6 errors in 29.23s ===================
The reason will be displayed to describe this comment to others. Learn more.
These error messages don't seem to have anything to do with ruff. mcp seems to be flaky / difficult to test, as is fastapi-mcp.
I'd say this update is fine.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Things done
Diff: astral-sh/ruff@refs/tags/0.11.12...refs/tags/0.11.13
Changelog: https://github.com/astral-sh/ruff/releases/tag/0.11.13
cc @bengsparks
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.